all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager/widget-toolkit/docs v3 00/19] notifications: notification metadata matching improvements
@ 2024-02-16  9:15 Lukas Wagner
  2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 01/19] api: notifications: add 'smtp' to target index Lukas Wagner
                   ` (18 more replies)
  0 siblings, 19 replies; 24+ messages in thread
From: Lukas Wagner @ 2024-02-16  9:15 UTC (permalink / raw)
  To: pve-devel

This patch series attempts to improve the user experience when creating
notification matchers.

Some of the noteworthy changes:
  - Fixup inconsistent 'hostname' field. Some notification events sent
  the hostname including a domain, while other did not.
  This series unifies the behavior, now the field only includes the hostname
  without a domain. Also updated the docs to reflect this change.
  - Allow setting a custom backup job ID, similar how we handle it for
  sync/prune jobs in PBS (to allow recognizable names used in matchers)
  - Adding columns for backup job ID/replication job ID in the UI
  - New metadata fields:
    - backup-job: ID of the backup job (set for backups, unless they are 'ad-hoc' backups)
    - replication-job: ID of the replication job
  - Add an API that enumerates known notification metadata fields/values
  - Suggest known fields/values in match rule window
  - Some code clean up for match rule edit window
  - Extended the 'exact' match-field mode - it now allows setting multiple
    allowed values, separated via ',':
      e.g. `match-field exact:type=replication,fencing
    Originally, I created a separate 'list' match type for this, but
    since the semantics for a list with one value and 'exact' mode
    are identical, I decided to just extend 'exact'.
    This is a safe change since there are are no values where a ','
    makes any sense (config IDs, hostnames)

Changelog:
  - v3:
    - Drop already applied patches for `proxmox`
    - Rebase onto latest master - minor conflict resolution was needed
  - v2:
    - include 'type' metadata field for forwarded mails
      --> otherwise it's not possible to match them
    - include Maximilliano's T-b trailer in UI patches

pve-manager:

Lukas Wagner (11):
  api: notifications: add 'smtp' to target index
  api: jobs: vzdump: pass job 'id' parameter
  ui: dc: backup: send 'id' property when starting a backup job manually
  ui: dc: backup: show 'Job ID' column
  ui: dc: backup: allow to set custom job id in  advanced settings
  api: replication: add 'replication-job' to notification metadata
  ui: replication: show 'Job ID' column
  vzdump: apt: notification: do not include domain in 'hostname' field
  api: replication: include 'hostname' field for notifications
  api: notification: add API for getting known metadata fields/values
  ui: utils: add overrides for translatable notification fields/values

 PVE/API2/APT.pm                   |   3 +-
 PVE/API2/Cluster/Notifications.pm | 155 +++++++++++++++++++++++++++++-
 PVE/API2/Replication.pm           |   4 +-
 PVE/API2/VZDump.pm                |   8 ++
 PVE/Jobs/VZDump.pm                |   4 +-
 PVE/VZDump.pm                     |  14 +--
 www/manager6/Utils.js             |  16 +++
 www/manager6/dc/Backup.js         |  15 ++-
 www/manager6/grid/Replication.js  |   3 +-
 9 files changed, 206 insertions(+), 16 deletions(-)


proxmox-widget-toolkit:

Lukas Wagner (5):
  combogrid: add 'showClearTrigger' config
  notification: matcher: match-field: show known fields/values
  notification: matcher: move match-field formulas to local viewModel
  notification: matcher: move match-calendar fields to panel
  notification: matcher: move match-severity fields to panel

 src/Utils.js                          |  31 ++
 src/data/model/NotificationConfig.js  |  12 +
 src/form/ComboGrid.js                 |   6 +-
 src/window/NotificationMatcherEdit.js | 613 ++++++++++++++++++--------
 4 files changed, 477 insertions(+), 185 deletions(-)


pve-docs:

Lukas Wagner (3):
  notification: clarify that 'hostname' does not include the domain
  notifications: describe new notification metadata fields
  notifications: match-field 'exact'-mode can now match multiple values

 notifications.adoc | 39 ++++++++++++++++++---------------------
 1 file changed, 18 insertions(+), 21 deletions(-)


Summary over all repositories:
  14 files changed, 701 insertions(+), 222 deletions(-)

-- 
Generated by git-murpp 0.5.0




^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2024-02-23 13:47 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-16  9:15 [pve-devel] [PATCH manager/widget-toolkit/docs v3 00/19] notifications: notification metadata matching improvements Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 01/19] api: notifications: add 'smtp' to target index Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 02/19] api: jobs: vzdump: pass job 'id' parameter Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 03/19] ui: dc: backup: send 'id' property when starting a backup job manually Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column Lukas Wagner
2024-02-20 15:23   ` Thomas Lamprecht
2024-02-20 15:38     ` Lukas Wagner
2024-02-20 16:26       ` Thomas Lamprecht
2024-02-23 13:46         ` Thomas Lamprecht
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 05/19] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 06/19] api: replication: add 'replication-job' to notification metadata Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 07/19] ui: replication: show 'Job ID' column Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 08/19] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 09/19] api: replication: include 'hostname' field for notifications Lukas Wagner
2024-02-16  9:15 ` [pve-devel] [PATCH manager v3 10/19] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH manager v3 11/19] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH widget-toolkit v3 12/19] combogrid: add 'showClearTrigger' config Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH widget-toolkit v3 13/19] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH widget-toolkit v3 14/19] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH widget-toolkit v3 15/19] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH widget-toolkit v3 16/19] notification: matcher: move match-severity " Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH docs v3 17/19] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH docs v3 18/19] notifications: describe new notification metadata fields Lukas Wagner
2024-02-16  9:16 ` [pve-devel] [PATCH docs v3 19/19] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal