From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly
Date: Mon, 12 Jun 2023 13:26:57 +0200 [thread overview]
Message-ID: <8a6e9649-3f68-8a03-254d-ce25fee21545@proxmox.com> (raw)
In-Reply-To: <cb3113c8-2d77-bceb-56d5-31db0f3d4b48@proxmox.com>
Am 12.06.23 um 13:22 schrieb Fiona Ebner:
> Am 09.05.23 um 10:46 schrieb Christoph Heiss:
>> + my $err = '';
>> + $run_params{logfunc} = sub { $err .= "QEMU: $1\r\n"; };
>
> Style nit: please use $run_params->{logfunc}
Please ignore me here, didn't realize it wasn't a hash reference, but a
hash at first. I guess it wouldn't just be style otherwise :)
next prev parent reply other threads:[~2023-06-12 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 8:46 Christoph Heiss
2023-06-12 11:22 ` Fiona Ebner
2023-06-12 11:26 ` Fiona Ebner [this message]
2023-06-12 14:54 ` Thomas Lamprecht
2023-06-13 7:05 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6e9649-3f68-8a03-254d-ce25fee21545@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.