From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique
Date: Wed, 27 Mar 2024 11:26:00 +0100 [thread overview]
Message-ID: <88bf83e4-eb41-4682-a4db-50eed90d872f@proxmox.com> (raw)
In-Reply-To: <20240326132556.4050167-1-a.lauterer@proxmox.com>
Am 26/03/2024 um 14:25 schrieb Aaron Lauterer:
> by adding a new checkbox and render the grid accordingly.
>
> If unique MAC addresses are enabled, set them to undefined when getting
> the values from the grid.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> not sure if setting `uniqueMac` directly on the component is okay.
> Though we do that dynamically for the `vmConfig` as well. So probably
> okayish.
>
> www/manager6/window/GuestImport.js | 39 +++++++++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
>
applied, with a follow-up to rework this using the viewModel for tracking
the state instead of doing that in a config option of the widget, thanks!
next prev parent reply other threads:[~2024-03-27 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 13:25 [pve-devel] " Aaron Lauterer
2024-03-27 10:26 ` Thomas Lamprecht [this message]
2024-03-27 10:32 ` [pve-devel] applied: " Aaron Lauterer
2024-03-27 10:33 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88bf83e4-eb41-4682-a4db-50eed90d872f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal