From: Christian Ebner <c.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/4] chunk store: return chunk extension and check for used marker
Date: Thu, 11 Dec 2025 12:28:28 +0100 [thread overview]
Message-ID: <88a73c30-8571-4623-a081-4b9f06327359@proxmox.com> (raw)
In-Reply-To: <176537651811.371273.12546243384711800815@yuna.proxmox.com>
On 12/10/25 3:21 PM, Fabian Grünbichler wrote:
> Quoting Christian Ebner (2025-11-26 14:34:19)
>> Clearly distinguish the cases for `bad` and `using` extensions for
>> items returned by the chunk iterator. Directory entries with
>> filenames which matched the expected length but not the extension
>> are now skipped over.
>
> I think we could go a step further and also move the parsing/rendering to
> ChunkExt everywhere we currently do it? which I guess is mostly
> verification/GC? not sure whether ChunkExt or a new Chunk struct that also
> contains the digest would be a better fit though..
Yes, will include that in v2. Thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-12-11 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 13:34 [pbs-devel] [PATCH proxmox-backup 0/4] followups for garbage collection Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 1/4] GC: Move S3 delete list state and logic to a dedicated struct Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 2/4] chunk store: rename and limit scope for chunk store iterator Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 3/4] chunk store: invert chunk filename checks in " Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 4/4] chunk store: return chunk extension and check for used marker Christian Ebner
2025-12-10 14:21 ` Fabian Grünbichler
2025-12-11 11:28 ` Christian Ebner [this message]
2025-12-10 14:18 ` [pbs-devel] [PATCH proxmox-backup 0/4] followups for garbage collection Fabian Grünbichler
2025-12-11 15:39 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a73c30-8571-4623-a081-4b9f06327359@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.