From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs
Date: Thu, 26 Mar 2026 13:55:39 +0100 [thread overview]
Message-ID: <88a50335-f75b-4c6b-b2c6-ed906e3c7013@proxmox.com> (raw)
In-Reply-To: <20260325213415.3861690-5-t.lamprecht@proxmox.com>
Am 25.03.26 um 10:34 PM schrieb Thomas Lamprecht:
> These settings are already in the (QEMU guest) agent property, and we
> do not use the guest- prefix for any of the existing properties
> (fstrim or freeze-fs-on-backup), and moving freeze-fs-on-backup to a
> generic variant is less confusing if one just drops the "-on-backup"
> part, i.e. no point in inventing a new name schema just for the sake
> of it.
There's an inconsistency in naming between fstrim and freeze-fs too, but
maybe we shouldn't care.
>
> We already rolled this the guest-fsfreeze name to pve-test, so lets
> add an alias, but as we do not provide API stability guarantees for
> test packages this is really just for convenience for anybody that
> tested this, I'm more than fine with dropping such a (never stable)
> released key again on a major release with the respective upgrade
> check in our pveXtoY tool.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2026-03-26 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 21:28 [PATCH qemu-server v2 0/4] rework fs-freeze agent property Thomas Lamprecht
2026-03-25 21:28 ` [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-27 1:12 ` Thomas Lamprecht
2026-03-25 21:28 ` [PATCH qemu-server v2 2/4] agent: treat freeze-fs-on-backup as alias for guest-fsfreeze Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-26 23:05 ` Thomas Lamprecht
2026-03-27 8:53 ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 3/4] tests: cfg2cmd: add agent guest-fsfreeze config tests Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs Thomas Lamprecht
2026-03-26 9:08 ` Maximiliano Sandoval
2026-03-26 21:46 ` Thomas Lamprecht
2026-03-26 12:55 ` Fiona Ebner [this message]
2026-03-26 23:16 ` applied: [PATCH qemu-server v2 0/4] rework fs-freeze agent property Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a50335-f75b-4c6b-b2c6-ed906e3c7013@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.