all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] fix: toolkit: make email regex pattern match pve-common
Date: Mon, 12 Sep 2022 17:15:34 +0200	[thread overview]
Message-ID: <889998f9-57d4-906e-cbf9-c4be0244725b@proxmox.com> (raw)
In-Reply-To: <20220907093740.172217-1-s.sterz@proxmox.com>

Am 07/09/2022 um 11:37 schrieb Stefan Sterz:
> `proxmoxMail` used its own regex pattern to validate emails. that
> meant certain email addresses were rejected by the front-end that
> were accepted by the backend that uses the functionality from
> `pve-common`. examples include the following:
> 
> - "user@host.test-tld"
> - "user-@host.testtld"
> - "user@host"
> 
> reported on the forum: https://forum.proxmox.com/threads/gui-bugulance-using-the-user-add-gui-interface.114743/
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> note that there are many many regex patterns that could be used
> (e.g.: [1]). im partial to w3c's approach [2], mainly because it's
> likely to be widely used, while being fairly simple and compatible
> with perl and javascript.
> 
> [1]: https://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html
> [2]: https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
> 
>  src/Toolkit.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-09-12 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  9:37 [pve-devel] " Stefan Sterz
2022-09-12 15:15 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=889998f9-57d4-906e-cbf9-c4be0244725b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal