all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login
@ 2025-12-18 12:42 Dominik Rusovac
  2025-12-18 12:42 ` [pve-devel] [PATCH proxmox-backup 1/1] " Dominik Rusovac
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dominik Rusovac @ 2025-12-18 12:42 UTC (permalink / raw)
  To: pve-devel; +Cc: Dominik Rusovac

The bug relates to PBS, but mentions that the same problem persisted for PVE,
which I could reproduce.

So, I fixed the bug for both products by the making the realm selection during
user creation not stateful, after talking to Dominik Csapak (thx btw).


proxmox-backup:

Dominik Rusovac (1):
  fix #7149: ui: prohibit realm update on login

 www/window/UserEdit.js | 1 +
 1 file changed, 1 insertion(+)


pve-manager:

Dominik Rusovac (1):
  fix #7149: ui: prohibit realm update on login

 www/manager6/dc/UserEdit.js | 1 +
 1 file changed, 1 insertion(+)


Summary over all repositories:
  2 files changed, 2 insertions(+), 0 deletions(-)

-- 
Generated by murpp 0.9.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH proxmox-backup 1/1] fix #7149: ui: prohibit realm update on login
  2025-12-18 12:42 [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login Dominik Rusovac
@ 2025-12-18 12:42 ` Dominik Rusovac
  2025-12-18 12:42 ` [pve-devel] [PATCH pve-manager " Dominik Rusovac
  2025-12-19  8:23 ` [pve-devel] [PATCH manager/proxmox-backup 0/2] " Dominik Csapak
  2 siblings, 0 replies; 4+ messages in thread
From: Dominik Rusovac @ 2025-12-18 12:42 UTC (permalink / raw)
  To: pve-devel; +Cc: Dominik Rusovac

The realm selection during user creation is no longer stateful. Hence,
as desired, adding a new user does not affect the realm on the login
page.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
 www/window/UserEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js
index a11507a7..9d9fc9c7 100644
--- a/www/window/UserEdit.js
+++ b/www/window/UserEdit.js
@@ -80,6 +80,7 @@ Ext.define('PBS.window.UserEdit', {
                 bind: {
                     value: '{realm}',
                 },
+                stateful: false, // realm is not saved between page reloads
                 cbind: {
                     hidden: '{!isCreate}',
                     disabled: '{!isCreate}',
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH pve-manager 1/1] fix #7149: ui: prohibit realm update on login
  2025-12-18 12:42 [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login Dominik Rusovac
  2025-12-18 12:42 ` [pve-devel] [PATCH proxmox-backup 1/1] " Dominik Rusovac
@ 2025-12-18 12:42 ` Dominik Rusovac
  2025-12-19  8:23 ` [pve-devel] [PATCH manager/proxmox-backup 0/2] " Dominik Csapak
  2 siblings, 0 replies; 4+ messages in thread
From: Dominik Rusovac @ 2025-12-18 12:42 UTC (permalink / raw)
  To: pve-devel; +Cc: Dominik Rusovac

The realm selection during user creation is no longer stateful. Hence,
as desired, adding a new user does not affect the realm on the login
page.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
 www/manager6/dc/UserEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js
index 7541816b..84d9cfa8 100644
--- a/www/manager6/dc/UserEdit.js
+++ b/www/manager6/dc/UserEdit.js
@@ -99,6 +99,7 @@ Ext.define('PVE.dc.UserEdit', {
             column1.splice(1, 0, {
                 xtype: 'pmxRealmComboBox',
                 name: 'realm',
+                stateful: false, // realm is not saved between page reloads
                 fieldLabel: gettext('Realm'),
                 allowBlank: false,
                 matchFieldWidth: false,
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login
  2025-12-18 12:42 [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login Dominik Rusovac
  2025-12-18 12:42 ` [pve-devel] [PATCH proxmox-backup 1/1] " Dominik Rusovac
  2025-12-18 12:42 ` [pve-devel] [PATCH pve-manager " Dominik Rusovac
@ 2025-12-19  8:23 ` Dominik Csapak
  2 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2025-12-19  8:23 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Rusovac

Looks good to me,

consider both patches

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 12/18/25 1:42 PM, Dominik Rusovac wrote:
> The bug relates to PBS, but mentions that the same problem persisted for PVE,
> which I could reproduce.
> 
> So, I fixed the bug for both products by the making the realm selection during
> user creation not stateful, after talking to Dominik Csapak (thx btw).
> 
> 
> proxmox-backup:
> 
> Dominik Rusovac (1):
>    fix #7149: ui: prohibit realm update on login
> 
>   www/window/UserEdit.js | 1 +
>   1 file changed, 1 insertion(+)
> 
> 
> pve-manager:
> 
> Dominik Rusovac (1):
>    fix #7149: ui: prohibit realm update on login
> 
>   www/manager6/dc/UserEdit.js | 1 +
>   1 file changed, 1 insertion(+)
> 
> 
> Summary over all repositories:
>    2 files changed, 2 insertions(+), 0 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-19  8:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 12:42 [pve-devel] [PATCH manager/proxmox-backup 0/2] fix #7149: ui: prohibit realm update on login Dominik Rusovac
2025-12-18 12:42 ` [pve-devel] [PATCH proxmox-backup 1/1] " Dominik Rusovac
2025-12-18 12:42 ` [pve-devel] [PATCH pve-manager " Dominik Rusovac
2025-12-19  8:23 ` [pve-devel] [PATCH manager/proxmox-backup 0/2] " Dominik Csapak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal