Re: [pve-devel] [PATCH FOLLOW-UP manager/widget-toolkit 0/2] replace SafeDestroy

["Michael Köppl" <m.koeppl@proxmox.com>]

This is made obsolete by: https://lore.proxmox.com/pve-devel/20250930145848.263162-1-m.koeppl@proxmox.com/

On 9/24/25 6:17 PM, Michael Köppl wrote:
> This is a follow-up to another series implementing an additional purge
> param for resource removal [0].
> 
> The ConfirmRemoveDialog window covers the SafeDestroy window's
> functionality, but makes it more general-purpose/flexible. It can be
> used for both yes/no dialog as well as the SafeDestroy dialogs already
> used for guests/storages. The reason for adding ConfirmRemoveDialog was
> that Ext.Msg.MessageBox is not properly extendable and simply adding an
> additional dialog would result in duplicate functionality covered in
> both SafeDestroy and ConfirmRemoveDialog. Thus, replace SafeDestroy with
> ConfirmRemoveDialog.
> 
> [0] https://lore.proxmox.com/pve-devel/20250924160747.430018-1-m.koeppl@proxmox.com/
> 
> proxmox-widget-toolkit:
> 
> Michael Köppl (1):
>   window: remove SafeDestroy
> 
>  src/Makefile              |   1 -
>  src/window/SafeDestroy.js | 207 --------------------------------------
>  2 files changed, 208 deletions(-)
>  delete mode 100644 src/window/SafeDestroy.js
> 
> 
> pve-manager:
> 
> Michael Köppl (1):
>   ui: replace SafeDestroy with ConfirmRemoveDialog
> 
>  www/manager6/window/SafeDestroyGuest.js   | 26 ++++++++++++++++++++++-
>  www/manager6/window/SafeDestroyStorage.js | 23 +++++++++++++++++++-
>  2 files changed, 47 insertions(+), 2 deletions(-)
> 
> 
> Summary over all repositories:
>   4 files changed, 47 insertions(+), 210 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel