From: Daniel Herzig <d.herzig@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab
Date: Wed, 08 Jan 2025 16:58:57 +0100 [thread overview]
Message-ID: <87r05djnzy.fsf@proxmox.com> (raw)
In-Reply-To: <20250108143812.241488-1-g.goller@proxmox.com> (Gabriel Goller's message of "Wed, 8 Jan 2025 15:38:09 +0100")
I just tested this series against an alpine container with sdn simple zone dhcp
IP assignment and it seems to do what it promises.
This makes a very nice streamlined experience with VM behaviour.
Tested-by: Daniel Herzig <d.herzig@proxmox.com>
Gabriel Goller <g.goller@proxmox.com> writes:
> Show the ip/hwaddress of the network interfaces of containers in the summary
> tab of the container and in the network tab on a per-interface basis.
>
> This series was originally by Leo Nunner:
> https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/
>
> v4, thanks @Daniel:
> - remove duplicate code (copy paste error)
> - rebase on latest master
>
> v3, thanks @Thomas, @Maximiliano:
> - fixed wording in schema description
> - stay backwards-compatible by keeping old attributes
> - use array reference instead of array
>
> v2, thanks @Dominik:
> - show if ip is static or dynamic (dhcp)
> - show multiple ips per interface
> - refactor/reuse AgentIPView instead of adding ContainerIPView component
> - various other small improvements
>
> manager:
>
> Gabriel Goller (2):
> lxc: show dynamically assigned IPs in network tab
> guest: refactor and reuse AgentIPView for containers
>
> www/manager6/Makefile | 2 +-
> www/manager6/lxc/Network.js | 85 +++++++----
> www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++-
> www/manager6/panel/GuestSummary.js | 2 +-
> .../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++--------
> 5 files changed, 211 insertions(+), 97 deletions(-)
> rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%)
>
>
> container:
>
> Gabriel Goller (1):
> api: return all addresses of an interface
>
> src/PVE/API2/LXC.pm | 37 +++++++++++++++++++++++++++++++++++--
> src/PVE/LXC.pm | 15 +++++++++++++++
> 2 files changed, 50 insertions(+), 2 deletions(-)
>
>
> Summary over all repositories:
> 7 files changed, 261 insertions(+), 99 deletions(-)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-08 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:38 Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-04-07 17:46 ` Thomas Lamprecht
2025-04-08 10:06 ` Gabriel Goller
2025-04-08 10:18 ` Thomas Lamprecht
2025-04-08 11:27 ` Gabriel Goller
2025-04-08 11:30 ` Thomas Lamprecht
2025-04-08 12:15 ` Gabriel Goller
2025-04-08 12:20 ` Thomas Lamprecht
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH container v4 3/3] api: return all addresses of an interface Gabriel Goller
2025-04-07 17:55 ` [pve-devel] applied: " Thomas Lamprecht
2025-01-08 15:58 ` Daniel Herzig [this message]
2025-05-27 14:06 ` [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r05djnzy.fsf@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal