From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm
Date: Wed, 14 Jun 2023 17:42:48 +0200 [thread overview]
Message-ID: <873b789f-9825-0c5f-ba99-b3fd04aff124@proxmox.com> (raw)
In-Reply-To: <20230613084401.1282876-2-d.csapak@proxmox.com>
Am 13/06/2023 um 10:43 schrieb Dominik Csapak:
> by adding an empty text to the dropdown, and disabling the other
> possibly invalid fields, so that it's clear why the panel is invalid
>
> as soon as there is an ldap/ad realm, it gets autoselected anyway and
> the fields get re-enabled.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * fix eslint warnings
> www/manager6/dc/RealmSyncJob.js | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
applied series with two minor UX follow ups and one small code clean-up
for the run-now API call handlers, thanks!
next prev parent reply other threads:[~2023-06-14 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:43 [pve-devel] [PATCH manager v2 0/4] improve ui for reaml sync jobs Dominik Csapak
2023-06-13 8:43 ` [pve-devel] [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm Dominik Csapak
2023-06-14 15:42 ` Thomas Lamprecht [this message]
2023-06-13 8:43 ` [pve-devel] [PATCH manager v2 2/4] ui: realm sync: change enabled column rendering Dominik Csapak
2023-06-13 8:44 ` [pve-devel] [PATCH manager v2 3/4] ui: realm: move sync job panel into realm panel Dominik Csapak
2023-06-13 8:44 ` [pve-devel] [PATCH manager v2 4/4] ui: realm sync: add 'run now' button Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873b789f-9825-0c5f-ba99-b3fd04aff124@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.