[pbs-devel] [PATCH proxmox-backup v3] fix #4971: client: Improve output on successful snapshot deletion

[pbs-devel] [PATCH proxmox-backup v3] fix #4971: client: Improve output on successful snapshot deletion

[Philipp Hufnagl]

When a snapshot gets deleted (forgotten), the proxmox backup client
currently returns returns
"Result: {
  "data": null
}"

This feedback may confuse users therefore this patch removes the output.

Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---

Changes since v1
* Remove output message

Changes since v2
* Change commit message

 proxmox-backup-client/src/snapshot.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
index 4ca8015f..fcfe5840 100644
--- a/proxmox-backup-client/src/snapshot.rs
+++ b/proxmox-backup-client/src/snapshot.rs
@@ -188,13 +188,13 @@ async fn forget_snapshots(param: Value) -> Result<Value, Error> {
 
     let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store());
 
-    let result = client
+    client
         .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?))
         .await?;
 
     record_repository(&repo);
 
-    Ok(result)
+    Ok(Value::Null)
 }
 
 #[api(
-- 
2.39.2

[pbs-devel] applied: [PATCH proxmox-backup v3] fix #4971: client: Improve output on successful snapshot deletion

[Thomas Lamprecht]

Am 16/10/2023 um 13:40 schrieb Philipp Hufnagl:
> When a snapshot gets deleted (forgotten), the proxmox backup client
> currently returns returns
> "Result: {
>   "data": null
> }"
> 
> This feedback may confuse users therefore this patch removes the output.
> 
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
> 
> Changes since v1
> * Remove output message
> 
> Changes since v2
> * Change commit message
> 
>  proxmox-backup-client/src/snapshot.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


applied, with a small follow-up (see below), thanks!

> 
> diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
> index 4ca8015f..fcfe5840 100644
> --- a/proxmox-backup-client/src/snapshot.rs
> +++ b/proxmox-backup-client/src/snapshot.rs
> @@ -188,13 +188,13 @@ async fn forget_snapshots(param: Value) -> Result<Value, Error> {
>  
>      let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store());
>  
> -    let result = client
> +    client
>          .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?))
>          .await?;
>  
>      record_repository(&repo);
>  
> -    Ok(result)
> +    Ok(Value::Null)

One small thing, sorry to not have caught this earlier, but as we no
never return a serde_json::Value, it'd a bit cleaner to return an empty
tuple here via `Ok(())` and change the functions' signature
respectively.

I fixed that in a follow-up, IMO it was to small of a change to warrant
a v4 here.