Re: [pve-devel] [PATCH manager v2] 8 to 9 checks: do not ask bootctl if systemd-boot is used.

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.08.25 um 1:03 PM schrieb Stoiko Ivanov:
>   get systemd-boot installed to /boot/efi upon upgrade

What problems does this cause (except for the false positive)? Can/do
users need to do something to recover? If yes, I think we should have
the script output more information.

> @@ -1624,18 +1624,11 @@ sub check_bootloader {
>          }
>      } else {
>          if (-f "/usr/share/doc/systemd-boot/changelog.Debian.gz") {
> -            my $exit_code = eval {
> -                run_command(['bootctl', 'is-installed', '--quiet', '--graceful'], noerr => 1);
> -            };
> -            if ($exit_code != 0) {
> -                log_warn(
> -                    "systemd-boot meta-package installed but the system does not seem to use it"
> -                        . " for booting. This can cause problems on upgrades of other boot-related packages."
> -                        . " Consider removing 'systemd-boot'");
> -            } else {
> -                log_info("systemd-boot used as bootloader and fitting meta-package installed.");
> -                return;
> -            }
> +            log_warn(
> +                "systemd-boot meta-package installed. This can cause problems on upgrades of other"
> +                ." boot-related packages. Unless you manually setup the system to use"
> +                ." systemd-boot remove 'systemd-boot'");
> +            return;

Note that we did not return in the 'if' branch previously, which means
the next check below won't be done anymore. Is that intentional? It
seems like it should be done.

>          }
>          if (!-f "/usr/share/doc/grub-efi-amd64/changelog.Debian.gz") {
>              log_warn("System booted in uefi mode but grub-efi-amd64 meta-package not installed,"



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel