From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname
Date: Fri, 1 Mar 2024 10:45:37 +0100 (CET) [thread overview]
Message-ID: <868581888.7040.1709286337762@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.311.1709219402.434.pve-devel@lists.proxmox.com>
> On 29.2.2024 16:09 CET Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com> wrote:
> All in all, yes, this is specific for our use case, otherwise
> parse_volname would already have that additional parameter as all the
> other plugin functions, but I don't see where this would hurt existing
> code, and it certainly helps us to enable reassigning disks to VMs.
> Passing in a param all other functions already get access to also does
> not sound too terrible to me.
>
> If there are further questions please feel free to ask.
Are you aware that parse_volname() is sometimes called for
all volumes, i.e inside volume_is_base_and_used().
Would that be fast enough? IMHO its a bad idea to make a network query for each volume there...
next prev parent reply other threads:[~2024-03-01 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240223092436.202277-1-roland.kammerer@linbit.com>
[not found] ` <20240223092436.202277-2-roland.kammerer@linbit.com>
2024-02-29 13:29 ` Fiona Ebner
[not found] ` <mailman.311.1709219402.434.pve-devel@lists.proxmox.com>
2024-03-01 9:45 ` Dietmar Maurer [this message]
2024-03-05 12:13 ` Fabian Grünbichler
2024-03-05 11:13 ` Thomas Lamprecht
2024-03-13 15:38 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868581888.7040.1709286337762@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.