From: Daniel Kral <d.kral@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Herzig <d.herzig@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 11/12] fix #4225: ui: qemu: cdedit: enable required checkbox for isos
Date: Thu, 16 Jan 2025 16:19:22 +0100 [thread overview]
Message-ID: <8648f6fc-80e8-49c7-bb24-b20d6dd0f20c@proxmox.com> (raw)
In-Reply-To: <20250113085608.99498-12-d.herzig@proxmox.com>
On 1/13/25 09:56, Daniel Herzig wrote:
> Enables the 'required' checkbox for the IsoSelector.
> If the parameter is not set, the backend will use the default (set to
> 1).
>
> Behaviour:
> * Only send parameter if not default (required=0)
> * Checked if parameter is missing (default)
> * Unchecked when adding a new CD-ROM
IMO the part of this patch where new VMs get created with `required=0`
CDROMs should be split into its own patch and marked as "for-9.0" or
else add a TODO comment for the 9.0 release.
Else this looks good, so consider this:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-16 15:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 8:55 [pve-devel] [PATCH v2 qemu-server, manager 00/12] bugzilla #4225 -- improve handling of unavailable ISOs Daniel Herzig
2025-01-13 8:55 ` [pve-devel] [PATCH v2 1/12] fix #4225: qemuserver: drive: add optional required parameter Daniel Herzig
2025-01-13 8:55 ` [pve-devel] [PATCH v2 2/12] qemuserver: add helper function for mocking files Daniel Herzig
2025-01-16 15:18 ` Daniel Kral
2025-01-17 11:36 ` Daniel Herzig
2025-01-13 8:55 ` [pve-devel] [PATCH v2 3/12] fix #4225: qemuserver: add function to eject isofiles Daniel Herzig
2025-01-16 15:19 ` Daniel Kral
2025-01-17 12:32 ` Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 4/12] test: chomp all trailing newlines from errors and warnings Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 5/12] test: mock cifs-store Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 6/12] test: add nfs-offline storage Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 7/12] test: mock existing files Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 8/12] test: mock log_warn warnings Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 9/12] test: cfg2cmd: add tests for testing the iso required parameter Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 10/12] fix #4225: ui: form: isoselector: add optional required checkbox Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 11/12] fix #4225: ui: qemu: cdedit: enable required checkbox for isos Daniel Herzig
2025-01-16 15:19 ` Daniel Kral [this message]
2025-01-17 12:38 ` Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms Daniel Herzig
2025-01-16 15:19 ` Daniel Kral
2025-01-17 12:47 ` Daniel Herzig
2025-01-23 16:39 ` Friedrich Weber
2025-01-24 7:35 ` Daniel Herzig
2025-01-16 15:18 ` [pve-devel] [PATCH v2 qemu-server, manager 00/12] bugzilla #4225 -- improve handling of unavailable ISOs Daniel Kral
2025-01-17 11:34 ` Daniel Herzig
2025-01-17 13:04 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8648f6fc-80e8-49c7-bb24-b20d6dd0f20c@proxmox.com \
--to=d.kral@proxmox.com \
--cc=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.