[pbs-devel] applied: [PATCH v2 proxmox-backup] pxar: bin: rework and dynamically generate `list` test data

[pbs-devel] applied: [PATCH v2 proxmox-backup] pxar: bin: rework and dynamically generate `list` test data

[Thomas Lamprecht]

Am 11/09/2024 um 12:47 schrieb Christian Ebner:
> Commit f16c5de757 ("pxar: bin: test `pxar list` with payload-input")
> introduced a regression test for listing of split pxar archives. This
> test relies on a large pxar blob file, the large size (> 100M) being
> overlooked when writing the test.
> 
> In order to not depend on this file any further in the future, drop
> it and rewrite the test to dynamically generate the files, needed and
> further extend the test thereby also cover the archive creation and
> extraction for split pxar archives.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> 
> Changes since version 1:
> 
> - Fix copy paste error: destination directory must be different from
>   source directory. Thanks Thomas for noticing!
> - Limit source to `test_files_and_subdirs` folder, otherwise rsync
>   might detect content mismatches after archive extraction, as the
>   other test for pxar also writes into the same folder.
> 
>  pxar-bin/tests/pxar.rs                       | 198 ++++++++-----------
>  tests/pxar/backup-client-pxar-expected.ppxar | Bin 104859264 -> 0 bytes
>  2 files changed, 80 insertions(+), 118 deletions(-)
>  delete mode 100644 tests/pxar/backup-client-pxar-expected.ppxar
> 
>

applied, thanks!

I'm still pondering about doing a force-push to erase this (for source code
repos) huge file from the git history. I.e. similar to the one from pve-manager
a bit over a year ago [0], the affected commit range would be still relatively
small at the moment..

[0]: https://lore.proxmox.com/pve-devel/e220f733-e96d-f83d-5afb-606199bc6fdc@proxmox.com/


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel