From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup] pxar: bin: rework and dynamically generate `list` test data
Date: Wed, 11 Sep 2024 16:10:14 +0200 [thread overview]
Message-ID: <85ba6056-8baf-4578-9cba-397a1c7ed02e@proxmox.com> (raw)
In-Reply-To: <20240911104722.238103-1-c.ebner@proxmox.com>
Am 11/09/2024 um 12:47 schrieb Christian Ebner:
> Commit f16c5de757 ("pxar: bin: test `pxar list` with payload-input")
> introduced a regression test for listing of split pxar archives. This
> test relies on a large pxar blob file, the large size (> 100M) being
> overlooked when writing the test.
>
> In order to not depend on this file any further in the future, drop
> it and rewrite the test to dynamically generate the files, needed and
> further extend the test thereby also cover the archive creation and
> extraction for split pxar archives.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>
> Changes since version 1:
>
> - Fix copy paste error: destination directory must be different from
> source directory. Thanks Thomas for noticing!
> - Limit source to `test_files_and_subdirs` folder, otherwise rsync
> might detect content mismatches after archive extraction, as the
> other test for pxar also writes into the same folder.
>
> pxar-bin/tests/pxar.rs | 198 ++++++++-----------
> tests/pxar/backup-client-pxar-expected.ppxar | Bin 104859264 -> 0 bytes
> 2 files changed, 80 insertions(+), 118 deletions(-)
> delete mode 100644 tests/pxar/backup-client-pxar-expected.ppxar
>
>
applied, thanks!
I'm still pondering about doing a force-push to erase this (for source code
repos) huge file from the git history. I.e. similar to the one from pve-manager
a bit over a year ago [0], the affected commit range would be still relatively
small at the moment..
[0]: https://lore.proxmox.com/pve-devel/e220f733-e96d-f83d-5afb-606199bc6fdc@proxmox.com/
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
parent reply other threads:[~2024-09-11 14:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240911104722.238103-1-c.ebner@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ba6056-8baf-4578-9cba-397a1c7ed02e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.