From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 2/2] ui: lxc: add edit window for device passthrough
Date: Wed, 17 Apr 2024 10:47:29 +0200 [thread overview]
Message-ID: <854e58be-ff75-4d71-ae4c-fe80522a1301@proxmox.com> (raw)
In-Reply-To: <96b03505-ddf8-4211-b935-4b2a4e6bdc66@proxmox.com>
Changed in patch v5. I also fixed a bug that ignored a custom devid when
creating a device passthrough.
https://lists.proxmox.com/pipermail/pve-devel/2024-April/063108.html
On 16/04/2024 15:57, Fiona Ebner wrote:
> Am 16.04.24 um 14:10 schrieb Filip Schauer:
>> +
>> + cbind: {
>> + confid: '{confid}',
>> + isCreate: get => !get('confid'),
>> + },
> Can't the above be removed while...
>
>> +
>> + items: [
>> + {
>> + xtype: 'proxmoxintegerfield',
>> + name: 'devid',
>> + fieldLabel: gettext('Passthrough ID'),
>> + minValue: 0,
>> + maxValue: PVE.Utils.dev_count - 1,
>> + hidden: true,
>> + allowBlank: false,
>> + disabled: true,
>> + labelAlign: 'right',
>> + bind: {
> ...using cbind instead of bind here?
>
>> + hidden: '{!isCreate}',
>> + disabled: '{!isCreate}',
>> + },
prev parent reply other threads:[~2024-04-17 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 12:10 [pve-devel] [PATCH v4 manager 0/2] " Filip Schauer
2024-04-16 12:10 ` [pve-devel] [PATCH v4 manager 1/2] utils: clarify naming of LXC mount point utils Filip Schauer
2024-04-16 12:10 ` [pve-devel] [PATCH v4 manager 2/2] ui: lxc: add edit window for device passthrough Filip Schauer
2024-04-16 13:57 ` Fiona Ebner
2024-04-17 8:47 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=854e58be-ff75-4d71-ae4c-fe80522a1301@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.