From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] add changes to support local biometric authentication
Date: Thu, 12 Nov 2020 16:39:31 +0100 [thread overview]
Message-ID: <848c3a27-b837-9848-c56a-f4fcef42caf9@proxmox.com> (raw)
In-Reply-To: <20200930103243.1200300-1-t.marx@proxmox.com>
Maybe a bit more explanation is needed for what this patch actually does.
Once enabled, a fingerprint scan is needed in the following situations:
* open the app
* navigate to the "Sites" panel
for the series:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 9/30/20 12:32 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx <t.marx@proxmox.com>
> ---
> android/app/src/debug/AndroidManifest.xml | 2 +
> android/app/src/main/AndroidManifest.xml | 1 +
> .../app/pve_flutter_frontend/MainActivity.kt | 4 +-
> pubspec.lock | 52 ++++++++++++-------
> 4 files changed, 38 insertions(+), 21 deletions(-)
>
> diff --git a/android/app/src/debug/AndroidManifest.xml b/android/app/src/debug/AndroidManifest.xml
> index 617ada1..dd99f60 100644
> --- a/android/app/src/debug/AndroidManifest.xml
> +++ b/android/app/src/debug/AndroidManifest.xml
> @@ -4,4 +4,6 @@
> to allow setting breakpoints, to provide hot reload, etc.
> -->
> <uses-permission android:name="android.permission.INTERNET"/>
> + <uses-permission android:name="android.permission.USE_FINGERPRINT"/>
> +
> </manifest>
> diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
> index 529671e..22e4a71 100644
> --- a/android/app/src/main/AndroidManifest.xml
> +++ b/android/app/src/main/AndroidManifest.xml
> @@ -2,6 +2,7 @@
> package="com.proxmox.app.pve_flutter_frontend">
>
> <uses-permission android:name="android.permission.INTERNET"/>
> + <uses-permission android:name="android.permission.USE_FINGERPRINT"/>
>
> <application
> android:label="Proxmox Virtual Environment"
> diff --git a/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt b/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> index 8b1e324..1458fa0 100644
> --- a/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> +++ b/android/app/src/main/kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt
> @@ -3,7 +3,7 @@ package com.proxmox.app.pve_flutter_frontend
> import android.content.ActivityNotFoundException
> import android.content.Intent
> import androidx.annotation.NonNull
> -import io.flutter.embedding.android.FlutterActivity
> +import io.flutter.embedding.android.FlutterFragmentActivity
> import io.flutter.embedding.engine.FlutterEngine
> import io.flutter.plugin.common.MethodChannel
> import androidx.core.content.FileProvider
> @@ -16,7 +16,7 @@ import java.io.IOException;
> import java.io.InputStream;
> import java.io.OutputStream;
>
> -class MainActivity: FlutterActivity() {
> +class MainActivity: FlutterFragmentActivity() {
>
> private val CHANNEL = "com.proxmox.app.pve_flutter_frontend/filesharing"
>
> diff --git a/pubspec.lock b/pubspec.lock
> index 831fd91..94886b3 100644
> --- a/pubspec.lock
> +++ b/pubspec.lock
> @@ -28,14 +28,14 @@ packages:
> name: async
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "2.5.0-nullsafety"
> + version: "2.5.0-nullsafety.1"
> boolean_selector:
> dependency: transitive
> description:
> name: boolean_selector
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "2.1.0-nullsafety"
> + version: "2.1.0-nullsafety.1"
> build:
> dependency: transitive
> description:
> @@ -105,14 +105,14 @@ packages:
> name: characters
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.1.0-nullsafety.2"
> + version: "1.1.0-nullsafety.3"
> charcode:
> dependency: transitive
> description:
> name: charcode
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.2.0-nullsafety"
> + version: "1.2.0-nullsafety.1"
> checked_yaml:
> dependency: transitive
> description:
> @@ -133,7 +133,7 @@ packages:
> name: clock
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.1.0-nullsafety"
> + version: "1.1.0-nullsafety.1"
> code_builder:
> dependency: transitive
> description:
> @@ -147,7 +147,7 @@ packages:
> name: collection
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.15.0-nullsafety.2"
> + version: "1.15.0-nullsafety.3"
> convert:
> dependency: transitive
> description:
> @@ -189,7 +189,7 @@ packages:
> name: fake_async
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.1.0-nullsafety"
> + version: "1.2.0-nullsafety.1"
> ffi:
> dependency: transitive
> description:
> @@ -216,6 +216,13 @@ packages:
> description: flutter
> source: sdk
> version: "0.0.0"
> + flutter_plugin_android_lifecycle:
> + dependency: transitive
> + description:
> + name: flutter_plugin_android_lifecycle
> + url: "https://pub.dartlang.org"
> + source: hosted
> + version: "1.0.11"
> flutter_test:
> dependency: "direct dev"
> description: flutter
> @@ -303,6 +310,13 @@ packages:
> url: "https://pub.dartlang.org"
> source: hosted
> version: "3.1.0"
> + local_auth:
> + dependency: transitive
> + description:
> + name: local_auth
> + url: "https://pub.dartlang.org"
> + source: hosted
> + version: "0.6.3+2"
> logging:
> dependency: transitive
> description:
> @@ -316,14 +330,14 @@ packages:
> name: matcher
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "0.12.10-nullsafety"
> + version: "0.12.10-nullsafety.1"
> meta:
> dependency: "direct main"
> description:
> name: meta
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.3.0-nullsafety.2"
> + version: "1.3.0-nullsafety.3"
> mime:
> dependency: transitive
> description:
> @@ -365,7 +379,7 @@ packages:
> name: path
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.8.0-nullsafety"
> + version: "1.8.0-nullsafety.1"
> path_provider:
> dependency: "direct main"
> description:
> @@ -573,21 +587,21 @@ packages:
> name: source_span
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.8.0-nullsafety"
> + version: "1.8.0-nullsafety.2"
> stack_trace:
> dependency: transitive
> description:
> name: stack_trace
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.10.0-nullsafety"
> + version: "1.10.0-nullsafety.1"
> stream_channel:
> dependency: transitive
> description:
> name: stream_channel
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "2.1.0-nullsafety"
> + version: "2.1.0-nullsafety.1"
> stream_transform:
> dependency: transitive
> description:
> @@ -601,21 +615,21 @@ packages:
> name: string_scanner
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.1.0-nullsafety"
> + version: "1.1.0-nullsafety.1"
> term_glyph:
> dependency: transitive
> description:
> name: term_glyph
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.2.0-nullsafety"
> + version: "1.2.0-nullsafety.1"
> test_api:
> dependency: transitive
> description:
> name: test_api
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "0.2.19-nullsafety"
> + version: "0.2.19-nullsafety.2"
> timing:
> dependency: transitive
> description:
> @@ -629,7 +643,7 @@ packages:
> name: typed_data
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "1.3.0-nullsafety.2"
> + version: "1.3.0-nullsafety.3"
> url_launcher:
> dependency: "direct main"
> description:
> @@ -678,7 +692,7 @@ packages:
> name: vector_math
> url: "https://pub.dartlang.org"
> source: hosted
> - version: "2.1.0-nullsafety.2"
> + version: "2.1.0-nullsafety.3"
> watcher:
> dependency: transitive
> description:
> @@ -715,5 +729,5 @@ packages:
> source: hosted
> version: "2.2.1"
> sdks:
> - dart: ">=2.10.0-0.0.dev <2.10.0"
> + dart: ">=2.10.0-110 <=2.11.0-176.0.dev"
> flutter: ">=1.12.13+hotfix.5 <2.0.0"
>
prev parent reply other threads:[~2020-11-12 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 10:32 Tim Marx
2020-09-30 10:32 ` [pve-devel] [PATCH proxmox_login_manager] add option for " Tim Marx
2020-11-12 15:39 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=848c3a27-b837-9848-c56a-f4fcef42caf9@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal