From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Tim Marx <t.marx@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend 1/3] add class for Proxmox corporate identity colors
Date: Wed, 30 Sep 2020 13:13:19 +0200 [thread overview]
Message-ID: <8430b937-96db-f4ee-3dfc-a7d97be97251@proxmox.com> (raw)
In-Reply-To: <444711761.793.1601463274808@webmail.proxmox.com>
On 9/30/20 12:54 PM, Tim Marx wrote:
[...]
>> diff --git a/lib/utils/promox_colors.dart b/lib/utils/promox_colors.dart
>> new file mode 100644
>> index 0000000..f45ef3d
>> --- /dev/null
>> +++ b/lib/utils/promox_colors.dart
>> @@ -0,0 +1,10 @@
>> +import 'package:flutter/material.dart';
>> +
>> +class ProxmoxColors {
>> + static final Color orange = Color(0xFFE57000);
>> + static final Color black = Color(0xFF000000);
>> + static final Color supportLightOrange = Color(0xFFFF9100);
>> + static final Color supportGrey = Color(0xFFABBABA);
>> + static final Color supportBlue = Color(0xFF00617F);
>> + static final Color supportDarkGrey = Color(0xFF464D4D);
>> +}
>
> With the exception of supportBlue (why support?) none of these colors are used why should we add them if they aren't used anywhere?
>
Having all company CI (corporate identity) colors readily available helps to avoid choosing some random color if a CI color would be appropriate as well as having to look them up manually.
The colors are taken from the Brand Guidelines [0] and besides black and orange, which are the main colors, they are categorized as "supporting" colors. I wanted to have that distinction in some way.
More colors are used in the welcome screen to have changing background colors.
> Black is definitely not a color we need to define.
With the idea of having all company colors collected in one place, I would make the argument, that black should be part of it. If defined as Color(0xFF000000) or as Colors.black might be another discussion.
[0] https://www.proxmox.com/en/news/media-kit
next prev parent reply other threads:[~2020-09-30 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 12:28 [pve-devel] [PATCH pve_flutter_frontend 0/3] Add first welcome screen Aaron Lauterer
2020-09-28 12:28 ` [pve-devel] [PATCH pve_flutter_frontend 1/3] add class for Proxmox corporate identity colors Aaron Lauterer
2020-09-30 10:54 ` Tim Marx
2020-09-30 11:13 ` Aaron Lauterer [this message]
2020-09-28 12:28 ` [pve-devel] [PATCH pve_flutter_frontend 2/3] add Proxmox symbol logo white orange Aaron Lauterer
2020-09-30 11:08 ` Tim Marx
2020-09-30 11:22 ` Aaron Lauterer
2020-09-28 12:28 ` [pve-devel] [PATCH pve_flutter_frontend 3/3] Add first welcome screen Aaron Lauterer
2020-09-28 13:41 ` Aaron Lauterer
2020-09-30 12:04 ` Tim Marx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8430b937-96db-f4ee-3dfc-a7d97be97251@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.marx@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal