[pve-devel] [PATCH-SERIE proxmox-widget-toolkit/pve-manager] ceph ui: add pg warning state

[pve-devel] [PATCH-SERIE proxmox-widget-toolkit/pve-manager] ceph ui: add pg warning state

[Alexandre Derumier]

This patch serie improve ceph dashboard adding a new pg warning state.
Currently undersized pg displayed as error state, and degraded as working state.

working is now displayed with blue color, and warning with orange color

changelog v2:
 - fix Aaron comments

proxmox-widget-toolkit:

Alexandre Derumier (1):
  css: add .working color #3892d4

 src/css/ext6-pmx.css | 4 ++++
 1 file changed, 4 insertions(+)

pve-manager:

Alexandre Derumier (1):
  ui: ceph status: add pg warning state

 www/manager6/ceph/StatusDetail.js | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

-- 
2.39.2

[pve-devel] [PATCH proxmox-widget-toolkit 1/1] css: add .working color #3892d4

[Alexandre Derumier]

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 src/css/ext6-pmx.css | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
index 2ffd2a8..9344595 100644
--- a/src/css/ext6-pmx.css
+++ b/src/css/ext6-pmx.css
@@ -113,6 +113,10 @@
     color: #3892d4;
 }
 
+.working {
+    color: #3892d4;
+}
+
 .pwt-eol-icon {
     position: relative;
     float: left;
-- 
2.39.2

[pve-devel] [PATCH v2 pve-manager 1/1] ui: ceph status: add pg warning state

[Alexandre Derumier]

Like ceph mgr dashboard, we need a warning state.

- set degraded as warning instead working
- set undersized as warning instead error
- rename error as critical
- add "working" (info-blue) color for working state
- use warning (orange) color for warning state

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 www/manager6/ceph/StatusDetail.js | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js
index d6c0763b..cac6445d 100644
--- a/www/manager6/ceph/StatusDetail.js
+++ b/www/manager6/ceph/StatusDetail.js
@@ -94,6 +94,7 @@ Ext.define('PVE.ceph.StatusDetail', {
 	colors: [
 	    '#CFCFCF',
 	    '#21BF4B',
+	    '#3892d4',
 	    '#FFCC00',
 	    '#FF6C59',
 	],
@@ -152,7 +153,6 @@ Ext.define('PVE.ceph.StatusDetail', {
 	backfilling: 2,
 	creating: 2,
 	deep: 2,
-	degraded: 2,
 	forced_backfill: 2,
 	forced_recovery: 2,
 	peered: 2,
@@ -165,17 +165,20 @@ Ext.define('PVE.ceph.StatusDetail', {
 	snaptrim: 2,
 	snaptrim_wait: 2,
 
-	// error
-	backfill_toofull: 3,
-	backfill_unfound: 3,
-	down: 3,
-	incomplete: 3,
-	inconsistent: 3,
-	recovery_toofull: 3,
-	recovery_unfound: 3,
-	snaptrim_error: 3,
-	stale: 3,
+	//warning
+	degraded: 3,
 	undersized: 3,
+
+	// critical
+	backfill_toofull: 4,
+	backfill_unfound: 4,
+	down: 4,
+	incomplete: 4,
+	inconsistent: 4,
+	recovery_toofull: 4,
+	recovery_unfound: 4,
+	snaptrim_error: 4,
+	stale: 4,
     },
 
     statecategories: [
@@ -191,10 +194,14 @@ Ext.define('PVE.ceph.StatusDetail', {
 	},
 	{
 	    text: gettext('Working'),
+	    cls: 'working',
+	},
+	{
+	    text: gettext('Warning'),
 	    cls: 'warning',
 	},
 	{
-	    text: gettext('Error'),
+	    text: gettext('Critical'),
 	    cls: 'critical',
 	},
     ],
-- 
2.39.2

[pve-devel] applied: [PATCH v2 pve-manager 1/1] ui: ceph status: add pg warning state

[Thomas Lamprecht]

Am 23/06/2023 um 11:45 schrieb Alexandre Derumier:
> Like ceph mgr dashboard, we need a warning state.
> 
> - set degraded as warning instead working
> - set undersized as warning instead error
> - rename error as critical
> - add "working" (info-blue) color for working state
> - use warning (orange) color for warning state
> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  www/manager6/ceph/StatusDetail.js | 31 +++++++++++++++++++------------
>  1 file changed, 19 insertions(+), 12 deletions(-)
> 
>

applied, thanks!

I folded in the CSS class into this patch to be added to pve-manager's
CSS file for now and renamed "Working" into "Busy", which is IMO slightly
better conveying what we mean here.

Re: [pve-devel] [PATCH-SERIE proxmox-widget-toolkit/pve-manager] ceph ui: add pg warning state

[Aaron Lauterer]

sorry for missing this initially. Looks good and easy to distinguish now in the 
dark & light theme.


consider this:

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 6/23/23 11:45, Alexandre Derumier wrote:
> This patch serie improve ceph dashboard adding a new pg warning state.
> Currently undersized pg displayed as error state, and degraded as working state.
> 
> working is now displayed with blue color, and warning with orange color
> 
> changelog v2:
>   - fix Aaron comments
> 
> proxmox-widget-toolkit:
> 
> Alexandre Derumier (1):
>    css: add .working color #3892d4
> 
>   src/css/ext6-pmx.css | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> pve-manager:
> 
> Alexandre Derumier (1):
>    ui: ceph status: add pg warning state
> 
>   www/manager6/ceph/StatusDetail.js | 31 +++++++++++++++++++------------
>   1 file changed, 19 insertions(+), 12 deletions(-)
>