all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH] system options: fix eslint error
Date: Wed, 26 Feb 2025 13:56:09 +0100	[thread overview]
Message-ID: <841e9c21-0912-40e9-b750-30a416fa84b5@proxmox.com> (raw)
In-Reply-To: <20250226124530.328015-1-g.goller@proxmox.com>

Am 26.02.25 um 13:45 schrieb Gabriel Goller:
> Linter error "line too long".
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  js/SystemOptions.js | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/js/SystemOptions.js b/js/SystemOptions.js
> index cc098ceac907..7a933cd0ec26 100644
> --- a/js/SystemOptions.js
> +++ b/js/SystemOptions.js
> @@ -76,7 +76,11 @@ Ext.define('PMG.SystemOptions', {
>  			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
>  
>  	me.add_text_row('admin-mail-from', gettext("'From:' for Admin Mail"),
> -			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText, renderer: Ext.htmlEncode });
> +			{
> +			    deleteEmpty: true,
> +			    defaultValue: Proxmox.Utils.noneText,
> +			    renderer: Ext.htmlEncode,
> +			});
>  
>  	me.add_proxy_row('http_proxy', gettext("HTTP proxy"));
>  

FYI, this patch is obsolete as 0012b5d ("fix indentation and code style
for various Options grid") was pushed a bit over two hours ago.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


  reply	other threads:[~2025-02-26 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 12:45 Gabriel Goller
2025-02-26 12:56 ` Thomas Lamprecht [this message]
2025-02-26 12:57   ` Gabriel Goller
2025-02-26 13:05     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841e9c21-0912-40e9-b750-30a416fa84b5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal