From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] api: nodeconfig: validate acme config before writing
Date: Mon, 28 Jun 2021 15:27:41 +0200 [thread overview]
Message-ID: <83d3d44c-358c-6a85-c988-d9e5a76d8048@proxmox.com> (raw)
In-Reply-To: <20210616183640.3930-1-s.ivanov@proxmox.com>
On 16.06.21 20:36, Stoiko Ivanov wrote:
> Currently it is possible to add the same domains as different
> acmedomainX keys to the node config, which prevents the user from
> ordering certificates later.
>
> This patch adds a call to get_acme_conf, which does the semantic
> validation (and is also used in all other sites, which read the
> config).
>
> Reported in our community forum:
> https://forum.proxmox.com/threads/lets-encrypt-cert-on-gui-not-working.91014/
>
> quickly tested in my setup, by successfully adding the same domain
> twice without the patch, and failing to do so with it applied.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/API2/NodeConfig.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-28 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:36 [pmg-devel] " Stoiko Ivanov
2021-06-28 13:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d3d44c-358c-6a85-c988-d9e5a76d8048@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.