From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values
Date: Mon, 20 Mar 2023 16:09:38 +0100 [thread overview]
Message-ID: <837c5a31-c115-fb4a-74c4-96c629eb0b19@proxmox.com> (raw)
In-Reply-To: <3c2d120e-eb11-aa79-be1f-eba3879cd58a@proxmox.com>
Am 15/03/2023 um 10:54 schrieb Dominik Csapak:
> hi,
>
> so high level comment:
> i'd write most of what you wrote in the cover letter here in the commit message,
> makes it much more convenient to find it only via git ;)
>
> also i'm missing a bit the rationale for how the regex was chosen, besides
> that it works in some conditions
>
> further comment inline
>
> On 1/31/23 13:50, Christoph Heiss wrote:
>> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
>> ---
>> src/PVE/Auth/LDAP.pm | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>>
applied, with Dominiks R-b/T-b and more info and references added to the commit
message, thanks!
next prev parent reply other threads:[~2023-03-20 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 12:50 [pve-devel] [PATCH access-control/docs 0/2] fix #3748: Allow reserved characters in attribute values of LDAP DNs Christoph Heiss
2023-01-31 12:50 ` [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values Christoph Heiss
2023-03-15 9:54 ` Dominik Csapak
2023-03-15 11:17 ` Christoph Heiss
2023-03-15 11:41 ` Dominik Csapak
2023-03-15 12:07 ` Christoph Heiss
2023-03-15 12:12 ` Thomas Lamprecht
2023-03-20 15:09 ` Thomas Lamprecht [this message]
2023-01-31 12:50 ` [pve-devel] [PATCH docs 2/2] pveum: Document reserved characters and quoting of LDAP DNs Christoph Heiss
2023-03-20 16:01 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-14 9:48 ` [pve-devel] [PATCH access-control/docs 0/2] fix #3748: Allow reserved characters in attribute values " Christoph Heiss
2023-03-20 14:22 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837c5a31-c115-fb4a-74c4-96c629eb0b19@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.