From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATH proxmox-backup] fix #4380: stat() is run when file is executed
Date: Fri, 4 Aug 2023 09:42:40 +0200 [thread overview]
Message-ID: <836aff2c-4143-577c-5abe-f9601f77293f@proxmox.com> (raw)
In-Reply-To: <20230803152238.124625-1-g.goller@proxmox.com>
Am 03.08.23 um 17:22 schrieb Gabriel Goller:
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index 2577cf98..c573c2a3 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -434,6 +434,15 @@ impl Archiver {
> assert_single_path_component(os_file_name)?;
> let full_path = self.path.join(os_file_name);
>
> + let match_path = PathBuf::from("/").join(full_path.clone());
> + if self
> + .patterns
> + .matches(match_path.as_os_str().as_bytes(), None)
Is it fine to call matches() without the file mode in all cases? Can't
it make a difference for directory matching? If it's okay, please
explain why in the commit message.
next prev parent reply other threads:[~2023-08-04 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 15:22 Gabriel Goller
2023-08-04 7:42 ` Fiona Ebner [this message]
[not found] ` <d4bf032e-42c0-a0d7-5702-07aa9e230690@proxmox.com>
2023-08-04 8:20 ` Fiona Ebner
2023-08-04 8:35 ` Fabian Grünbichler
2023-08-04 8:21 ` Fabian Grünbichler
2023-08-04 8:52 ` Fiona Ebner
2023-08-04 12:08 ` Wolfgang Bumiller
2023-08-04 7:59 ` [pbs-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836aff2c-4143-577c-5abe-f9601f77293f@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.