all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 5/5] cpu config: die on hotplug of non x86_64 CPUs
Date: Mon, 11 Mar 2024 11:13:39 +0100	[thread overview]
Message-ID: <82fac45c-4c07-4e06-a62c-47d94f1d3acd@proxmox.com> (raw)
In-Reply-To: <ca9582b3-5f71-4191-a072-784227a2fd29@proxmox.com>

Here is a fixed patch v2:

https://lists.proxmox.com/pipermail/pve-devel/2024-March/062153.html

On 08/03/2024 14:53, Fiona Ebner wrote:
> Am 08.03.24 um 14:34 schrieb Thomas Lamprecht:
>> Am 21/02/2024 um 15:33 schrieb Filip Schauer:
>>> When attempting a CPU hotplug on an architecture other than x86_64, die
>>> with a clean error instead of attempting a hotplug with a known
>>> non-working device command line. Also move the corresponding FIXME up to
>>> the error.
>>>
>>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
>>> ---
>>>   PVE/QemuServer/CPUConfig.pm | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
>>> index 7d471f4..01e4515 100644
>>> --- a/PVE/QemuServer/CPUConfig.pm
>>> +++ b/PVE/QemuServer/CPUConfig.pm
>>> @@ -417,6 +417,9 @@ sub get_custom_model {
>>>   sub print_cpu_device {
>>>       my ($conf, $arch, $id) = @_;
>>>   
>>> +    # FIXME: hot plugging other architectures like our unofficial arch64 support?
>>> +    die "Hotplug of non x86_64 CPU not yet supported" if $arch != 'x86_64';
>> arbitrary strings need to be compared using `eq` and `ne`, as `==` and `!=` can
>> only be used for numerics or strings that can be interpreted to one, so this never
>> could work.
>>
>> Interestingly the if never triggers in the `!=` case but always triggers in the
>> `==` case.
>>
> Because strings that cannot be parsed as a number are interpreted as 0,
> so both (invalid) sides will be 0. Description of parsing rules (from
> [0], wasn't able to find in official docs):
>
>> It follows these basic rules:
>>
>>      Ignore leading whitespace. This is handy when you extract a field out of columnar data and the number doesn't take up the entire column.
>>      Allow for a single leading sign (+ or -)
>>      Skip leading zeros (so, no octal)
>>      Capture decimal ASCII digits (0,1,2,3,4,5,6,7,8,9), allowing for a single decimal point (so, no semantic versioning numbers)
>>      Stop at the first non-decimal-digit character
>>      Whatever you have so far is the number. If you have nothing, the number is 0.
>
> [0]:
> https://stackoverflow.com/questions/70482447/why-is-00-equal-to-0-in-perl/70496787#70496787




  reply	other threads:[~2024-03-11 10:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 14:33 [pve-devel] [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH common 1/1] tools: add is_native_arch to compare the CPU architecture Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 1/5] cpu config: add helper to get the default CPU type Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 2/5] prevent starting a 32-bit VM using a 64-bit OVMF BIOS Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 3/5] Move is_native from PVE::QemuServer to PVE::Tools Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 4/5] Unify the default value for 'kvm' Filip Schauer
2024-02-23 11:54   ` Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 5/5] cpu config: die on hotplug of non x86_64 CPUs Filip Schauer
2024-03-08 13:34   ` Thomas Lamprecht
2024-03-08 13:53     ` Fiona Ebner
2024-03-11 10:13       ` Filip Schauer [this message]
2024-03-08 13:34 ` [pve-devel] partially-applied-series: [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82fac45c-4c07-4e06-a62c-47d94f1d3acd@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal