Re: [pve-devel] [PATCH v3 storage] fix #5191: api, cli: implement moving a volume between storages

[Fiona Ebner <f.ebner@proxmox.com>]

Am 18.09.24 um 16:56 schrieb Filip Schauer:
> On 05/09/2024 14:12, Fiona Ebner wrote:
>>> @@ -483,15 +485,173 @@ __PACKAGE__->register_method ({
>>>       return $upid;
>>>       }});
>>>   +sub volume_move {
>> Should this even be a new top-level method? Or can/should we extend
>> export/import instead, to not only cover guest images? Because with this
>> top-level method we block the way for external storage plugins to
>> support this functionality too if they don't adhere to our assumptions.
> 
> 
> We do not use the existing export/import because we want to use `move`
> instead of copying when `--delete` is passed. This improves performance
> when moving between storages on the same storage backend.
> 

Is that really a common enough use case? I mean, can be fine if the
added complexity is not too much, but it feels a bit like duplication
since we could also re-use storage_migrate() and add the special casing
there.

> Other than that the feedback was incorporated in patch v4:
> https://lists.proxmox.com/pipermail/pve-devel/2024-September/065380.html
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel