all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api2/admin/datstore/status: improve status api call and restore compatibility
Date: Thu, 29 Oct 2020 12:32:49 +0100	[thread overview]
Message-ID: <82af148b-c659-f555-b777-875c9cc3602a@proxmox.com> (raw)
In-Reply-To: <20201029105126.8984-1-d.csapak@proxmox.com>

On 29.10.20 11:51, Dominik Csapak wrote:
> by moving the properties of the storage status out again to the top
> level object
> 
> also introduce proper structs for the types used, to get type-safety
> and better documentation for the api calls
> 
> this changes the backup counts from an array of [groups,snapshots] to
> an object/struct with { groups, snapshots } and include 'other' types
> (though we do not have any at this moment)
> 
> this way it is better documented
> 
> this also adapts the ui code to cope with the api changes
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> restores compatibility with client <=0.9.1 but breaks 0.9.2
>  src/api2/admin/datastore.rs      | 72 ++++++++++++++++----------------
>  src/api2/types/mod.rs            | 65 ++++++++++++++++++++++++++++
>  src/bin/proxmox-backup-client.rs |  2 +-
>  www/DataStoreSummary.js          | 26 ++++++------
>  4 files changed, 117 insertions(+), 48 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2020-10-29 11:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 10:51 [pbs-devel] " Dominik Csapak
2020-10-29 11:32 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82af148b-c659-f555-b777-875c9cc3602a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal