From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup] ui: sync job: fix source group filters based on sync direction
Date: Mon, 25 Nov 2024 15:50:30 +0100 [thread overview]
Message-ID: <829829bf-0cfd-4518-a994-b3ac0263c367@proxmox.com> (raw)
In-Reply-To: <20241125110323.169074-1-c.ebner@proxmox.com>
Am 25.11.24 um 12:03 schrieb Christian Ebner:
> Fix switching the source for group filters based on the sync jobs
> sync direction.
>
> The helper to set the local namespace for the group filers was
> introduced in commit 43a92c8c ("ui: group filter: allow to set
> namespace for local datastore"), but never used because lost during
> subsequent iterations of reworking the patch series.
>
> The switching is corrected by:
> - correctly initializing the local store and namespace for the group
> filer of sync jobs in push direction in the controller init, if a
> datastore is set.
> - fixing an incorrect check for the sync direction in the remote
> datastore selector change listener.
> - conditionally switching namespace to be set for the group filter in
> the remote and local namespace selector change listeners.
> - conditionally switching datastore to be set for the group filter in
> the local datastore selector change listener.
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1 (thanks @Dominik for catching the issues):
> - only init group filters if there is a datastore given
> - also switch group filters datastore when switching local datastore
> - removed unneeded setLocalDatastore, as setLocalNamespace sets
> datastore and namespace
> - fixed eslint issues
> - updated commit message
>
> www/window/SyncJobEdit.js | 31 +++++++++++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
>
applied, with Dominik's R-b and T-b, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-25 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 11:03 [pbs-devel] " Christian Ebner
2024-11-25 14:23 ` Dominik Csapak
2024-11-25 14:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829829bf-0cfd-4518-a994-b3ac0263c367@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.