Re: [pve-devel] [PATCH v2 manager 1/3] ui: lxc/qemu: add disk reassign

[Dominik Csapak <d.csapak@proxmox.com>]

On 3/4/22 14:29, Aaron Lauterer wrote:
>>> +            }); +        }, +        }); +    }, + +
>>> validateForm: function(fp, isValid) { +
>>> this.getView().lookup('submitButton').setDisabled(!isValid); +
>>> }, + +    onReassignClick: function() { +        let me = this; +
>>> let view = me.getView(); +        let form =
>>> view.lookup('moveFormPanel').getForm(); +        if
>>> (form.isValid()) { +
>>> me.reassign_disk(form.getValues()); +        } +    }, + +
>>> onMpTypeChange: function(value) { +
>>> this.getView().getViewModel().set('mpType', value.getValue()); +
>>> this.getView().lookup('mpIdSelector').validate(); +    },
>>
>> these functions make me question if it wouldn't have been easier to
>> use an 'edit window' instead? any reason for that?
> 
> It has been a while since I sent these patches, but I think there were a few reasons to go with a 
> regular window. One of them IIRC was that, similar to the resize and move windows, we also want to 
> show a custom labeled button "Reassign {Volume|Disk}"  instead of "OK" or one of the options we have 
> with the edit window.
> 

we have the 'submitText' property for the edit window which always takes precedence
so that shouldn't be the problem