From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] ui: resource tree: add collapse/expand all button
Date: Tue, 19 Nov 2024 20:56:35 +0100 [thread overview]
Message-ID: <822107fc-cb6e-4837-832e-96cba3f4cdff@proxmox.com> (raw)
In-Reply-To: <20241119094933.955006-1-d.csapak@proxmox.com>
Am 19.11.24 um 10:49 schrieb Dominik Csapak:
> adds two buttons to the tree: expand all and collapse all
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * use two buttons (negates the need for all the event handling and checking)
> * use plain plus/minus icons -> i have no real preference here either,
> but the plain icons look a bit weird here IMHO
It looks indeed odd, especially without padding. Did you try stacking them
like I mentioned in my reply as possible option. Did not see anny mentioning
that it didn't work or looked stupid ^^
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-19 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:49 Dominik Csapak
2024-11-19 19:56 ` Thomas Lamprecht [this message]
2024-11-20 8:35 ` Dominik Csapak
2024-11-20 8:56 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822107fc-cb6e-4837-832e-96cba3f4cdff@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.