From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH qemu] PVE: add zero block handling to PBS dump callback
Date: Wed, 19 Aug 2020 15:42:08 +0200 [thread overview]
Message-ID: <81d2255e-ac6b-f02a-958c-6e9e3a4a8ce1@proxmox.com> (raw)
In-Reply-To: <20200813115027.11333-1-s.reiter@proxmox.com>
On 13.08.20 13:50, Stefan Reiter wrote:
> Both the PBS and VMA dump callbacks assume that a NULL pointer can be
> passed as *pbuf, but that never happens, as backup-dump.c calls this
> function with contents of an iovec.
>
> So first, remove that assumption and add an 'assert' to verify.
>
> Secondly, while the vma-writer already does the buffer_is_zero check
> internally, for PBS we relied on that non-existant behaviour for zero
> chunks, so do the buffer_is_zero check manually and pass NULL to the
> rust lib in case it is true.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> This increases backup speed to PBS for VMs with free space quite dramatically.
>
> pve-backup.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>
applied, thanks!
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [pve-devel] [PATCH qemu] PVE: add zero block handling to PBS dump callback
Date: Wed, 19 Aug 2020 15:42:08 +0200 [thread overview]
Message-ID: <81d2255e-ac6b-f02a-958c-6e9e3a4a8ce1@proxmox.com> (raw)
In-Reply-To: <20200813115027.11333-1-s.reiter@proxmox.com>
On 13.08.20 13:50, Stefan Reiter wrote:
> Both the PBS and VMA dump callbacks assume that a NULL pointer can be
> passed as *pbuf, but that never happens, as backup-dump.c calls this
> function with contents of an iovec.
>
> So first, remove that assumption and add an 'assert' to verify.
>
> Secondly, while the vma-writer already does the buffer_is_zero check
> internally, for PBS we relied on that non-existant behaviour for zero
> chunks, so do the buffer_is_zero check manually and pass NULL to the
> rust lib in case it is true.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> This increases backup speed to PBS for VMs with free space quite dramatically.
>
> pve-backup.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2020-08-19 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 11:50 [pve-devel] " Stefan Reiter
2020-08-13 11:50 ` [pbs-devel] " Stefan Reiter
2020-08-19 13:42 ` Thomas Lamprecht [this message]
2020-08-19 13:42 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d2255e-ac6b-f02a-958c-6e9e3a4a8ce1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal