Re: [PATCH pve-manager 5/8] ui: Add CPU flag editor for custom models

[Fiona Ebner <f.ebner@proxmox.com>]

Am 12.03.26 um 9:40 AM schrieb Arthur Bied-Charreton:
> Add CPU flag editor to the CPUTypeEdit component, using the VMCPUFlagSelector
> also used in the VM creation flow. By default, only show the CPU flags that
> are currently meant to be shown in the VM creation window, see [0]. When in

In the VM Hardware/creation window, I think we should not allow
selecting the accelerator for the flags by the user, but use the
accelerator that the VM currently has configured. With a
hint/description that this is the currently configured one.

Nice work so far from both you and the original author!

> CPUTypeEdit, show all available flags.
> 
> For each flag in VMCPUFlagSelector, also display which node(s) it is available
> on to limit misconfigurations.
> 

---snip 8<---

> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index 74b1a2c4..06c9d9f1 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -1,3 +1,19 @@
> +const VM_CPU_FLAGS_SUBSET = {
> +    aes: true,
> +    'amd-no-ssb': true,
> +    'amd-ssbd': true,
> +    'hv-evmcs': true,
> +    'hv-tlbflush': true,
> +    ibpb: true,
> +    'md-clear': true,
> +    'nested-virt': true,
> +    pcid: true,
> +    pdpe1gb: true,
> +    'spec-ctrl': true,
> +    ssbd: true,
> +    'virt-ssbd': true,

I'd rather not have the list hard-coded here if it can be avoided and
from what we discussed for the qemu-server patches I think it won't be
needed anymore, right?