From: Filip Schauer <f.schauer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup v2 1/2] fix #5946: disks: wipe: ensure GPT header backup is wiped
Date: Wed, 12 Feb 2025 12:01:45 +0100 [thread overview]
Message-ID: <816b74c7-f690-46c6-8736-e852e41055a1@proxmox.com> (raw)
In-Reply-To: <97c61ed9-4c9d-4590-a90f-8a777f6e3e38@proxmox.com>
Superseded by:
https://lore.proxmox.com/pbs-devel/20250212105855.43853-1-f.schauer@proxmox.com/
On 11/02/2025 19:39, Thomas Lamprecht wrote:
> change-wise I'd have preferred switching over from dd to writing ourself
> in a first patch and then adding the code for clearing the GPT backup header
> in a second patch, that's much easier to process and review compared to
> mixing those two things.
Done in v3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-02-12 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 16:26 [pbs-devel] [PATCH backup v2 0/2] " Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
2025-02-11 18:39 ` Thomas Lamprecht
2025-02-12 11:01 ` Filip Schauer [this message]
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
2025-02-11 18:42 ` Thomas Lamprecht
2025-02-12 10:24 ` Filip Schauer
2025-02-12 13:44 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=816b74c7-f690-46c6-8736-e852e41055a1@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.