Re: [pve-devel] [PATCH docs v3 1/2] pvesr: update the chapter and bring it into good condition

[Daniel Kral <d.kral@proxmox.com>]

On 1/10/25 17:58, Alexander Zeidler wrote:
> Existing information is preserved in a restructured way and usefully
> supplemented.
> 
> * restructure and revise the introduction
> * add subchapter "Considerations"
> * remove the subchapter "Schedule Format" with its one line of content
>    and link where appropriate directly to the copy under "25. Appendix D:
>    Calendar Events". The help button at adding/editing a job links now to
>    the subchapter "Managing Jobs".
> * provide details on job removal and how to enforce it if necessary
> * add more helpful CLI examples and improve/fix existing ones
> * restructure and revise the subchapter "Error Handling"
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v3:
> * adapt the introduction and section "Risk of Data Loss" to provide
>    information about using a shared storage together with storage
>    replication
> * update the CLI example `pvesr update` (*:00 replaces incorrect */00)
> * implement most suggestions from Daniel Kral
> ** update commit message
> ** reword first paragraph of introduction
> ** rename subchapter "Recommendations" to "Considerations"
> ** write "every 15 minutes" to be consistent with UI (and additionally
>     mention that examples from the drop-down list can be modified)
> ** reword the description of the bandwidth limit
> 
> v2: https://lore.proxmox.com/pve-devel/20241218161948.3-1-a.zeidler@proxmox.com/
> * no changes, only add missing pve-manager patch
> 
>   pvecm.adoc |   2 +
>   pvesr.adoc | 411 +++++++++++++++++++++++++++++++++++++----------------
>   2 files changed, 287 insertions(+), 126 deletions(-)

I've read another time through the article and it reads great again - 
nothing to complain from my side ;). The description for why the anchors 
were created could've still landed in the commit message, but that's 
just a tiny nit for me.

Otherwise thanks for the great article, consider this:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel