From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, h.laimer@proxmox.com
Subject: Re: [pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg
Date: Wed, 2 Mar 2022 11:16:38 +0100 [thread overview]
Message-ID: <80447296-7315-6a9d-03a0-dccdc6a77189@proxmox.com> (raw)
In-Reply-To: <20220301085153.31445-3-h.laimer@proxmox.com>
Am 01.03.22 um 09:51 schrieb Hannes Laimer:
> ... on destroy if 'purge' is selected
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/PVE/API2/LXC.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 84712f7..2e4146e 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -758,6 +758,7 @@ __PACKAGE__->register_method({
> print "purging CT $vmid from related configurations..\n";
> PVE::ReplicationConfig::remove_vmid_jobs($vmid);
> PVE::VZDump::Plugin::remove_vmid_from_backup_jobs($vmid);
> + PVE::Jobs::Plugin::remove_vmid_from_jobs($vmid);
Should add a
use PVE::Jobs::Plugin;
(or PVE::Jobs if the function is moved there) to the imports.
Same for the next patch.
>
> if ($ha_managed) {
> PVE::HA::Config::delete_service_from_config("ct:$vmid");
next prev parent reply other threads:[~2022-03-02 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 8:51 [pve-devel] [PATCH-SERIES] fix #3903: remove vmid from jobs.cfg on destroy Hannes Laimer
2022-03-01 8:51 ` [pve-devel] [PATCH pve-manager 1/3] fix #3903: jobs-plugin: add remove vmid from jobs helper Hannes Laimer
2022-03-02 10:12 ` Fabian Ebner
2022-03-01 8:51 ` [pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg Hannes Laimer
2022-03-02 10:16 ` Fabian Ebner [this message]
2022-03-02 14:28 ` Hannes Laimer
2022-03-03 9:08 ` Fabian Ebner
2022-03-01 8:51 ` [pve-devel] [PATCH qemu-server 3/3] " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80447296-7315-6a9d-03a0-dccdc6a77189@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.