Re: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v7 00/21] Generate frr config using jinja templates and rust types

[Gabriel Goller <g.goller@proxmox.com>]

On 27.03.2026 02:11, Thomas Lamprecht wrote:
> Am 23.03.26 um 14:49 schrieb Gabriel Goller:
> > Previously we generated the frr config using one big perl hash, where every
> > controller-plugin and zone-plugin would push their stuff. This is not pretty
> > and also tricky to unite with our new rust-based fabrics. Furthermore the only
> > way to edit or override the frr config is currently the frr.conf.local file,
> > which is merged with the perl-hash in a very janky manner, which has sprouted
> > numerous forum threads. The main problem with the frr.conf.local is the limited
> > control which the user has as to where the override or additional config gets
> > placed. There are also a few config overrides or additions to frr.conf.local
> > that are currently impossible or generate invalid frr config.
> > 
> > To improve this we now ship templates, which we use to generate the frr config.
> > This is the way it is done in e.g. sonic and vyos. These jinja2 templates are
> > then populated using rust-structs. We changed the perl code to generate
> > bgp/evpn and isis config that can be deserialized by the rust types and then
> > rendered into a frr configuration using the templates.
> > 
> > # Versioning
> > 
> > The templates are in the proxmox-frr-templates debian package which, when
> > installed, copies the template into `/usr/share/proxmox-frr/templates`, where
> > they are read from using `include_str!`. This means the proxmox-frr-templates
> > package is only used for development and to version the templates. The user
> > only gets them in the binary of proxmox-frr (which, by extension, is in the
> > perl-rs shared library).
> > 
> > # frr.conf.local
> > 
> > The frr.conf.local merging code has been adjusted so that the frr.conf.local
> > still works as before.
> > 
> > This series requires:
> > https://lore.proxmox.com/pve-devel/20260323092140.42275-1-g.goller@proxmox.com/
> > 
> > Changelog:
> > 
> > v7 (thanks @Wolfgang, @Stefan):
> >   * ve-rs: remove `phf` dependency, use proxmox-sorted-macro and const array
> >     with binary_search lookup
> >   * ve-rs: add proxmox-frr unit-tests using vtysh dry-run to test them directly
> >     against the frr config parser (only if the vtysh binary exists)
> >   * ve-rs: use new from_str implementation of api_string_type! macro (requires:
> >     https://lore.proxmox.com/pve-devel/20260323092140.42275-1-g.goller@proxmox.com/)
> 
> Reads like a mature and well structured series, nice work!
> Some comments to specific patches, but most of it relatively benign (or at
> least easy to fix). With those addressed, if applicable, this would be IMO
> ready to be applied.
> 
> Please pick up Wolfgang R-b for a next submission, at least if you do not make
> bigger structural code changes. OTOH, I'd be open to squash in a few fixes and
> take this in after you checked the replies, just tell me what you favor; I'm
> also more then content with a v8 submission.

I'll send a v8 soon.