all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4646: Set BackupReader debug to current loglevel
Date: Thu, 17 Aug 2023 14:42:10 +0200	[thread overview]
Message-ID: <7g7uon2zdpu5jyomd7o2cu3wqwatsxszvrlz4e5k2eo6wr56t6@oumy5xgaoz3s> (raw)
In-Reply-To: <a38a6e56-da33-a176-dc52-63639e4d16c1@proxmox.com>

On Fri, Aug 11, 2023 at 02:53:17PM +0200, Gabriel Goller wrote:
> On a second note, how about we also introduce more fine-grained logging
> settings to the api/proxy?
> Currently on the api we hardcode the `log::max_level` to `LevelFilter::Info`
> and on the proxy we check
> if the environment variable `PROXMOX_DEBUG` is set and use
> `LevelFilter::Debug` if it exists. We could
> do the same as on the cli and allow `PROXMOX_DEBUG` (probably renaming it to
> `PROXMOX_LOG_LEVEL`
> or something) to be set to `trace`, `debug`, `info`, `warning` or `error`.
> Then we could also decide if we want to use the server `log::max_level` or
> the client-side `debug` flag in
> the `download_file` and `download_chunk` functions (where the original issue
> #4646 comes from).

A while ago we Hannes added `init_cli_logger` to proxmox-router which
the CLI binaries call with the `$PBS_LOG` env var.
Having the same mechanism for the daemons' log levels would probably
make sense. We should probably also call it PBS_LOG then.
People could probably temporarily change it via `systemctl
set-environment` or more permanently via an `Environment=` systemd
service snippet file.




  reply	other threads:[~2023-08-17 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 12:57 Gabriel Goller
2023-08-08 10:38 ` Wolfgang Bumiller
2023-08-09 15:06   ` Gabriel Goller
2023-08-11 12:53   ` Gabriel Goller
2023-08-17 12:42     ` Wolfgang Bumiller [this message]
2023-08-21 11:20       ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7g7uon2zdpu5jyomd7o2cu3wqwatsxszvrlz4e5k2eo6wr56t6@oumy5xgaoz3s \
    --to=w.bumiller@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal