[pve-devel] applied: [PATCH storage v3] dirplugin: fix #3986: check for trailing slashes

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 22.11.24 um 17:57 schrieb Daniel Herzig:
> Currently, setting up a directory storage with trailing slashes in
> the path results in log messages with double slashes, if this path
> gets expanded by an action like vzdump.
> 
> This patch removes those trailing slashes once the directory storage
> class config gets updated.
> 
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
> ---
> changes since v2:
> * make use of File::Spec->canonpath() for better readability
> 
> v2: https://lore.proxmox.com/pve-devel/20241122131305.59062-1-d.herzig@proxmox.com/
> 
> Thanks for the hint, Thomas!
> 
> Notes:
> 
> Functionality can be tested by adding new directory storage with trailing
> slashes either via the GUI or `pvesm add dir $STORAGENAME --path /some/path/`.
> 
> `/new/path/` will show up as `/new/path` in `/etc/pve/storage.cfg`, and trailing
> slashes from earlier defined directory storage paths will be removed.
> 
>  src/PVE/Storage/DirPlugin.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, with commit message/subject slightly adapted, e.g. mentioned
that this is mostly a cosmetic issue and moved the fix # to the front,
thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel