From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] auto-installer: fix: add default value for partition-label
Date: Fri, 15 Nov 2024 15:34:07 +0100 [thread overview]
Message-ID: <7f64c4d1-0f15-44b5-a6c6-ad97a64be09b@proxmox.com> (raw)
In-Reply-To: <20241115103248.205313-1-c.heiss@proxmox.com>
Am 15.11.24 um 11:32 schrieb Christoph Heiss:
> This ensure backwards-compatibility of older version of
> proxmox-auto-install-assistant and newer ISOs/auto-installer version.
>
> Otherwise, it fails with a "missing key `partition_label`" error on
> start.
>
> While proxmox-auto-install-assistant writes out that field by default
> now, it will be missing for ISOs prepared with older versions of that
> tool.
>
> Fix it by providing a default label, such that it always has a sensible
> value.
>
> Fixes: 2e89c07 ("auto-install-assistant: add new parameter to specify partition label")
> Reported-by: Timothy Nicholson <t.nicholson@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-auto-installer/src/utils.rs | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-15 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:32 [pve-devel] " Christoph Heiss
2024-11-15 14:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f64c4d1-0f15-44b5-a6c6-ad97a64be09b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal