From: Friedrich Weber <f.weber@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Fiona Ebner" <f.ebner@proxmox.com>
Cc: w.bumiller@proxmox.com
Subject: Re: [pve-devel] [PATCH storage] plugin: volume snapshot info: untaint snapshot filename
Date: Mon, 28 Jul 2025 15:32:15 +0200 [thread overview]
Message-ID: <7f609be6-b8f8-438e-9a02-1886be0ef4bc@proxmox.com> (raw)
In-Reply-To: <3d16f677-c0fc-4f1d-9e4b-02daecf9894b@proxmox.com>
On 28/07/2025 15:30, Friedrich Weber wrote:
[...]
>> should hopefully not be too hard to fix, I'll try to whip up patches..
>
> Thanks! I guess then (and if we want to add an untaint here at all) we
> could keep this patch as it is, because qemu-img info does seem to
> output an absolute "filename" even if the backing filename is absolute?
> What do you think?
Sorry, didn't see the apply. Thanks! A patch for run_command to always
pass untainted values could be done in addition, I guess.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-28 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 15:48 Friedrich Weber
2025-07-28 9:59 ` Fabian Grünbichler
2025-07-28 11:08 ` Fiona Ebner
2025-07-28 12:21 ` Fabian Grünbichler
2025-07-28 13:30 ` Friedrich Weber
2025-07-28 13:32 ` Friedrich Weber [this message]
2025-07-31 12:37 ` Friedrich Weber
2025-07-31 12:55 ` Fiona Ebner
2025-07-28 13:20 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f609be6-b8f8-438e-9a02-1886be0ef4bc@proxmox.com \
--to=f.weber@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.