From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] fix #6680: avoid setting nonexistent 'write-cache' option for scsi-{block, generic}
Date: Wed, 13 Aug 2025 12:35:08 +0200 [thread overview]
Message-ID: <7e4e21bf-b0b2-4584-8c09-2c1d22d2f35e@proxmox.com> (raw)
In-Reply-To: <1755079639.qwkpi5tsex.astroid@yuna.none>
Am 13.08.25 um 12:08 PM schrieb Fabian Grünbichler:
> On August 13, 2025 10:58 am, Fiona Ebner wrote:
>> @@ -1252,6 +1254,10 @@ sub print_drivedevice_full {
>> if (my $product = $drive->{product}) {
>> $device .= ",product=$product";
>> }
>> +
>> + $has_write_cache = 1;
>
> nit: this already is the default initial value above, and we don't loop
> over devices here? so we could drop this and the comment above
Yes, but since the SCSI branch does modify it in one place, I though it
is more readable and future-proof to be explicit covering both
sub-branches for the device types.
>
>> + } else {
>
> and instead add a comment here that -block and -generic don't support
> this?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-13 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 8:58 [pve-devel] [PATCH-SERIES qemu-server 0/2] fix scsi-{block, generic} with blockdev regressions Fiona Ebner
2025-08-13 8:58 ` [pve-devel] [PATCH qemu-server 1/2] fix #6680: avoid setting nonexistent 'write-cache' option for scsi-{block, generic} Fiona Ebner
2025-08-13 10:08 ` Fabian Grünbichler
2025-08-13 10:35 ` Fiona Ebner [this message]
2025-08-13 8:58 ` [pve-devel] [PATCH qemu-server 2/2] drive device: scsi: avoid setting nonexistent 'device_id' " Fiona Ebner
2025-08-13 14:14 ` [pve-devel] applied: [PATCH-SERIES qemu-server 0/2] fix scsi-{block, generic} with blockdev regressions Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e4e21bf-b0b2-4584-8c09-2c1d22d2f35e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.