From: Fiona Ebner <f.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter
Date: Mon, 25 Jul 2022 10:04:08 +0200 [thread overview]
Message-ID: <7e032d2a-389f-6df5-8ec9-0eca4d3e163e@proxmox.com> (raw)
In-Reply-To: <20220722105328.ryil3wqnumrrg7hd@wobu-vie.proxmox.com>
Am 22.07.22 um 12:53 schrieb Wolfgang Bumiller:
> On Wed, Jul 20, 2022 at 12:59:45PM +0200, Fabian Ebner wrote:
>> Instead, use the one from the initial configuration. The only current
>> caller is in PMG and the namespace parameter set there agrees with
>> the one from the initial configuration, so this is not actually a
>> breaking change.
>
> Still technically a breaking change ;-)
>
Yeah, should've written "not a breaking change in practice" instead.
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/PBSClient.pm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
>> index 34d3f67..d7dd6e1 100644
>> --- a/src/PVE/PBSClient.pm
>> +++ b/src/PVE/PBSClient.pm
>> @@ -274,7 +274,7 @@ sub get_snapshots {
>> # create a new PXAR backup of a FS directory tree - doesn't cross FS boundary
>> # by default.
>> sub backup_fs_tree {
>> - my ($self, $root, $id, $pxarname, $cmd_opts, $namespace) = @_;
>> + my ($self, $root, $id, $pxarname, $cmd_opts) = @_;
>
> And in theory the namespace *could* be overwritable via `$cmd_opts` (if
> we used `//=` below.
>
> But even better yet, since it's not used anywhere, maybe we should just
> drop `$cmd_opts` entirely?
>
Fine by me. If we need more flexibility in the future, we can still add
it back, maybe only exposing specific options rather than everything
run_raw_client_cmd can take.
>>
>> die "backup-id not provided\n" if !defined($id);
>> die "backup root dir not provided\n" if !defined($root);
>> @@ -288,7 +288,7 @@ sub backup_fs_tree {
>>
>> $cmd_opts //= {};
>>
>> - $cmd_opts->{namespace} = $namespace if defined($namespace);
>> + $cmd_opts->{namespace} = $self->{scfg}->{namespace} if defined($self->{scfg}->{namespace});
>>
>> return run_raw_client_cmd($self, 'backup', $param, %$cmd_opts);
>> };
>> --
>> 2.30.2
WARNING: multiple messages have this Message-ID
From: Fiona Ebner <f.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter
Date: Mon, 25 Jul 2022 10:04:08 +0200 [thread overview]
Message-ID: <7e032d2a-389f-6df5-8ec9-0eca4d3e163e@proxmox.com> (raw)
In-Reply-To: <20220722105328.ryil3wqnumrrg7hd@wobu-vie.proxmox.com>
Am 22.07.22 um 12:53 schrieb Wolfgang Bumiller:
> On Wed, Jul 20, 2022 at 12:59:45PM +0200, Fabian Ebner wrote:
>> Instead, use the one from the initial configuration. The only current
>> caller is in PMG and the namespace parameter set there agrees with
>> the one from the initial configuration, so this is not actually a
>> breaking change.
>
> Still technically a breaking change ;-)
>
Yeah, should've written "not a breaking change in practice" instead.
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/PBSClient.pm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
>> index 34d3f67..d7dd6e1 100644
>> --- a/src/PVE/PBSClient.pm
>> +++ b/src/PVE/PBSClient.pm
>> @@ -274,7 +274,7 @@ sub get_snapshots {
>> # create a new PXAR backup of a FS directory tree - doesn't cross FS boundary
>> # by default.
>> sub backup_fs_tree {
>> - my ($self, $root, $id, $pxarname, $cmd_opts, $namespace) = @_;
>> + my ($self, $root, $id, $pxarname, $cmd_opts) = @_;
>
> And in theory the namespace *could* be overwritable via `$cmd_opts` (if
> we used `//=` below.
>
> But even better yet, since it's not used anywhere, maybe we should just
> drop `$cmd_opts` entirely?
>
Fine by me. If we need more flexibility in the future, we can still add
it back, maybe only exposing specific options rather than everything
run_raw_client_cmd can take.
>>
>> die "backup-id not provided\n" if !defined($id);
>> die "backup root dir not provided\n" if !defined($root);
>> @@ -288,7 +288,7 @@ sub backup_fs_tree {
>>
>> $cmd_opts //= {};
>>
>> - $cmd_opts->{namespace} = $namespace if defined($namespace);
>> + $cmd_opts->{namespace} = $self->{scfg}->{namespace} if defined($self->{scfg}->{namespace});
>>
>> return run_raw_client_cmd($self, 'backup', $param, %$cmd_opts);
>> };
>> --
>> 2.30.2
next prev parent reply other threads:[~2022-07-25 8:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:59 [pve-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 8:44 ` [pve-devel] " Fiona Ebner
2022-11-04 8:44 ` Fiona Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-22 10:53 ` [pve-devel] " Wolfgang Bumiller
2022-07-22 10:53 ` [pmg-devel] " Wolfgang Bumiller
2022-07-25 8:04 ` Fiona Ebner [this message]
2022-07-25 8:04 ` Fiona Ebner
2022-11-04 13:16 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-11-04 13:16 ` [pmg-devel] " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 13:28 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-11-04 13:28 ` [pmg-devel] " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: " Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 13:17 ` [pve-devel] applied: " Wolfgang Bumiller
2022-11-04 13:17 ` [pmg-devel] " Wolfgang Bumiller
2022-10-04 8:08 ` [pve-devel] [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fiona Ebner
2022-10-04 8:08 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e032d2a-389f-6df5-8ec9-0eca4d3e163e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal