From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v5 manager 0/2] add edit window for device passthrough
Date: Wed, 17 Apr 2024 11:54:15 +0200 [thread overview]
Message-ID: <7d97b66f-4b3d-4276-908b-1d3ad3d91034@proxmox.com> (raw)
In-Reply-To: <20240417084419.37338-1-f.schauer@proxmox.com>
Am 17/04/2024 um 10:44 schrieb Filip Schauer:
> Changes since v4:
> * Simplify cbind
> * Fix selection of custom devid not being applied on creation in
> onGetValues
>
> Changes since v3:
> * Pass confid in via cbind instead of manually setting it in the view
> model
> * Check me.isCreate instead of !me.confid for whether to find the next
> free device slot
>
> Changes since v2:
> * Clarify naming of mount point and device passthrough related utils
> * Remove unnecessary cbind
> * Make the device index selectible
> * Add default values as emptyText to the UI elements
> * Reorder UI elements to improve the layout
> * Disable the Device Passthrough menu entries for non-root users
> * Change var to let
> * Minor code cleanup of DeviceEdit.js
>
> Changes since v1:
> * Remove usb mapping
> * Add mode, uid and gid fields
>
> Filip Schauer (2):
> utils: clarify naming of LXC mount point utils
> ui: lxc: add edit window for device passthrough
>
> www/manager6/Makefile | 1 +
> www/manager6/Utils.js | 23 ++-
> www/manager6/lxc/DeviceEdit.js | 176 +++++++++++++++++++++++
> www/manager6/lxc/MPEdit.js | 4 +-
> www/manager6/lxc/MultiMPEdit.js | 4 +-
> www/manager6/lxc/Resources.js | 33 ++++-
> www/manager6/window/GuestDiskReassign.js | 6 +-
> 7 files changed, 232 insertions(+), 15 deletions(-)
> create mode 100644 www/manager6/lxc/DeviceEdit.js
>
applied, with a follow-up that made the forEachLxc{MP,Dev} methods also
pass the property ID directly to the closure, thanks!
I also made some clean-ups, e.g. dropping the right-alignment of the field
label, that look just way to odd..
Allowing manual control over the ID also seems to not provide much advantage
here, so I hid that field like we do for VM PCI passthrough.
Also noticed something not related to the UI side: if I enter some bogus path,
like `/dev/enoent`, I correctly get an error that this does not exist, but the
config entry is added nonetheless!
Which then also means that if I keep the dialogue open and correct the dev
path, I won't be able to submit as the config digest changed, I need to close
and re-open the add/edit dialogue again. This is not only bad UX, but seems
completely broken?
Also, if I got some bogus devX entries already, the error I get when saving
a new one is often from them, not from the one I add, but the change also
goes through here...
Please check that out.
next prev parent reply other threads:[~2024-04-17 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:44 [pve-devel] " Filip Schauer
2024-04-17 8:44 ` [pve-devel] [PATCH v5 manager 1/2] utils: clarify naming of LXC mount point utils Filip Schauer
2024-04-17 8:44 ` [pve-devel] [PATCH v5 manager 2/2] ui: lxc: add edit window for device passthrough Filip Schauer
2024-04-17 9:54 ` Thomas Lamprecht [this message]
2024-04-17 10:03 ` [pve-devel] applied: [PATCH v5 manager 0/2] " Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d97b66f-4b3d-4276-908b-1d3ad3d91034@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal