From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] clone disk: force raw format for TPM state
Date: Thu, 17 Feb 2022 14:33:49 +0100 [thread overview]
Message-ID: <7cd9f084-8065-4c3f-8a65-a1df2021a848@proxmox.com> (raw)
In-Reply-To: <20220216104749.47039-1-f.ebner@proxmox.com>
On 16.02.22 11:47, Fabian Ebner wrote:
> The format can't be qcow2 for TPM state, because swtpm reads the file
> directly expecting raw data.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> The DiskStorageSelector in the UI hides the format for TPM state, but
> still sends along format=qcow2 triggering this bug. Still, the fix
> should be in the backend.
>
IMO the frontend shouldn't send that though and in a next major version the backend
should bail on that, as it can be confusing to do such things "magically".
> PVE/QemuServer.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2022-02-17 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:47 [pve-devel] " Fabian Ebner
2022-02-17 13:33 ` Thomas Lamprecht [this message]
2022-02-17 13:55 ` [pve-devel] applied: " Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd9f084-8065-4c3f-8a65-a1df2021a848@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.