all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: dc: backup: fix job detail search
Date: Tue, 22 Jun 2021 11:52:29 +0200	[thread overview]
Message-ID: <7c398ca5-0933-ac25-53cf-ad86c8586056@proxmox.com> (raw)
In-Reply-To: <20210622080726.2361527-1-a.lauterer@proxmox.com>

On 22.06.21 10:07, Aaron Lauterer wrote:
> 'for...in array' returns the id in the array but not the value,
> 'for...of array' returns the values.
> 
> Another issue that I ran into was if the property did not exist.

Having something like "another issue fixed with additional changes" is
always a good indicator that it could be a separate patch.

> 
> Checking if the property evaluates to false will catch situations where
> the property does not exist or is null. All other situations where there
> is a value for the name, id or type, should evaluate to true if present
> as they are strings or the VMID.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  www/manager6/dc/Backup.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, to both master and stable-6, thanks!




      reply	other threads:[~2021-06-22  9:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  8:07 [pve-devel] " Aaron Lauterer
2021-06-22  9:52 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c398ca5-0933-ac25-53cf-ad86c8586056@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal