Re: [PATCH proxmox 2/5] pbs-api-types: use match statement for maintenance mode check

[Christian Ebner <c.ebner@proxmox.com>]

On 6/3/26 1:03 PM, Robert Obkircher wrote:
> 
> On 03.06.26 12:35, Christian Ebner wrote:
>> only one question
>>
>> On 6/2/26 3:00 PM, Robert Obkircher wrote:
>>> Use an exhaustive match statement to be more explicit and to draw
>>> attention when new variants are added.
>>>
>>> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
>>
>> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
>>
>>> ---
>>>    pbs-api-types/src/maintenance.rs | 27 ++++++++++++---------------
>>>    1 file changed, 12 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/pbs-api-types/src/maintenance.rs
>>> b/pbs-api-types/src/maintenance.rs
>>> index 2adb5d84..7def498b 100644
>>> --- a/pbs-api-types/src/maintenance.rs
>>> +++ b/pbs-api-types/src/maintenance.rs
>>> @@ -94,25 +94,22 @@ impl MaintenanceMode {
>>>        }
>>>          pub fn check(&self, operation: Operation) -> Result<(),
>>> Error> {
>>> -        if self.ty == MaintenanceType::Delete {
>>> -            bail!("datastore is being deleted");
>>> -        }
>>> -
>>>            let message =
>>> percent_encoding::percent_decode_str(self.message.as_deref().unwrap_or(""))
>>>                .decode_utf8()
>>>                .unwrap_or(Cow::Borrowed(""));
>>
>> question: should we also avoid decoding the message if not using it?
>> Maybe by defining a closure for it?
> 
> This should be fairly cheap in the common case where self.message is
> None.
> 
> The bigger issue is that the message is never percent-encoded in the
> first place. I'd also avoid adding ": " if there is no message. I was
> going to address this in a v2 for [1] but I can also add a patch to
> this series.
> 
> [1]
> https://lore.proxmox.com/pbs-devel/50fe57b6-d7d4-40a1-9e17-bc904ea30cdd@proxmox.com/

Yes, question was rather if it is cheaper to bypass it altogether. But 
not that relevant here, can remain as is here (and the rest addressed in 
you other series).