Re: [PATCH proxmox 1/5] pbs-api-types: propagate maintenance mode parse errors

[Christian Ebner <c.ebner@proxmox.com>]

a few minor comments only

On 6/2/26 3:00 PM, Robert Obkircher wrote:
> Do not silently ignore errors if the config file is invalid or
> contains a new mode from a future version.

The commit message should also include an explicit statement that 
set_maintenance_mode() now fails when mode cannot be parsed and that 
this does not interfere with the current behavior when `enum-fallback` 
is enabled.

> Upgrades to the new GarbageCollection maintenance mode should be fine
> even without this change, becausue it is unlikely that someone can
> enable it before older processes stop initiating new backups or S3
> refreshes. There is however a risk that a sync job could unmount the
> datastore.
> 
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   pbs-api-types/src/datastore.rs | 22 +++++++++++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 7643b0de..b770bc03 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -629,18 +629,22 @@ impl DataStoreConfig {
>           }
>       }
>   
> -    pub fn get_maintenance_mode(&self) -> Option<MaintenanceMode> {
> -        self.maintenance_mode.as_ref().and_then(|str| {
> -            MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new(
> -                str,
> -                &MaintenanceMode::API_SCHEMA,
> -            ))
> -            .ok()
> -        })
> +    pub fn get_maintenance_mode(&self) -> Result<Option<MaintenanceMode>, Error> {
> +        self.maintenance_mode
> +            .as_ref()
> +            .map(|str| {
> +                MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new(
> +                    str,
> +                    &MaintenanceMode::API_SCHEMA,
> +                ))
> +                .map_err(|e| format_err!("failed to parse maintenance mode: {e}"))
> +            })
> +            .transpose()
>       }
>   
>       pub fn set_maintenance_mode(&mut self, new_mode: Option<MaintenanceMode>) -> Result<(), Error> {
> -        let current_type = self.get_maintenance_mode().map(|mode| mode.ty);
> +        // it is probably best to error out if the current mode can't be parsed:

This comment would benefit from including a bit more reasoning:
e.g. never allow setting of maintenance mode on parsing errors for 
current mode, possible new maintenance type variant.

> +        let current_type = self.get_maintenance_mode()?.map(|mode| mode.ty);
>           let new_type = new_mode.as_ref().map(|mode| mode.ty);
>   
>           match current_type {

Slightly unrelated, but since noted during review and and this fits to 
the patch series: the docstrings for `ty` in MaintenanceMode and 
`maintenance_mode` in DataStoreConfig are outdated and need to be updated.


With that addressed:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>