From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>,
pve-devel@pve.proxmox.com
Subject: Re: [pve-devel] [PATCH v4 manager 1/5] api: backup: add endpoint to list included guests and volumes
Date: Wed, 8 Jul 2020 09:11:09 +0200 [thread overview]
Message-ID: <7bc54d06-3004-3b8c-e7c8-1f12f9ac3746@proxmox.com> (raw)
In-Reply-To: <20200707094902.24712-2-a.lauterer@proxmox.com>
On 07.07.20 11:48, Aaron Lauterer wrote:
> This patch adds a new API endpoint that returns a list of included
> guests, their volumes and whether they are included in a backup.
>
> The output is formatted to be used with the extJS tree panel.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> The return types are `qemu`, `lxc` and `unknown`. The latter is there on
> purpose because it is possible that a deleted but not purged VM is still
> configured on a backup job. While the backup job itself will fail, I
> think it is good to show it in the job detail view so users can react to
> it.
>
> v3 -> v4:
> * remove the "not all permissions" field as we never show such
> notifications anywhere else. This makes the returned data simpler
> * define objects to be pushed in the return data directly in the push
> operation and not way ahead in the code.
>
> v2 -> v3 (hopefully I got them all):
> * incorporate feedback from thomas
> * changed double negative for permissions `not_all_permissions` to
> `permissions_for_all`
> * adapted to latest changes to return values from `get_included_guests`
> * define $guest only once
> * return VMID as int
> * renamed some vars to be more descriptive
>
> v1 -> v2:
> * simplified the code
> * refactored according to feedback
>
>
> PVE/API2/Backup.pm | 174 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 174 insertions(+)
>
> diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
> index 86377c0a..6fbe2106 100644
> --- a/PVE/API2/<F2>Backup.pm
A <F2> slipped into here, git am -3 handles it like a champ though..
Further, when applying this series I get:
> implement me - abstract method (500)
In the detail window, am I still missing some other part or package bump?
next prev parent reply other threads:[~2020-07-08 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:48 [pve-devel] [PATCH v4 manager 0/5] add backup detail and not backed up view Aaron Lauterer
2020-07-07 9:48 ` [pve-devel] [PATCH v4 manager 1/5] api: backup: add endpoint to list included guests and volumes Aaron Lauterer
2020-07-08 7:11 ` Thomas Lamprecht [this message]
2020-07-08 7:21 ` Aaron Lauterer
2020-07-07 9:48 ` [pve-devel] [PATCH v4 manager 2/5] gui: dc/backup: move renderers to Utils.js Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 3/5] gui: dc/backup: add new backup job detail view Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 4/5] fix #2609 api: backupinfo: add non job specific endpoint Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 5/5] fix #2609 gui: backup: add window for not backed guests Aaron Lauterer
2020-07-09 18:06 ` [pve-devel] applied-series: Re: [PATCH v4 manager 0/5] add backup detail and not backed up view Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bc54d06-3004-3b8c-e7c8-1f12f9ac3746@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal