Re: [pve-devel] [PATCH ha-manager 2/2] add api getter/setter for node maintenance mode

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 27/08/2025 10:26, Daniel Kral wrote:
> On Tue Aug 26, 2025 at 6:00 PM CEST, Thomas Skinner wrote:
>> On Tue, Aug 26, 2025 at 4:38 AM Daniel Kral <d.kral@proxmox.com> wrote:
>>> I think the GET /cluster/ha/nodes/{node}/maintenance API endpoint should
>>> be integrated into the GET /cluster/ha/nodes/{node} instead as putting a
>>> node in/out of maintenance mode is only an action, but the state could
>>> be more than just the node being in maintenance mode.
>>>
>>> On second thought, is this API endpoint even used at all in the patch
>>> series?
>>
>> The API isn't specifically used here, but we have found it useful in
>> our local branch to have it so that we can query the transition of the
>> state of a host directly. I figured someone else might find it useful
>> as well, so I left it in here. If it should be removed, I can remove
>> it in the v2 series.
> 
> I see, the only thing I'm still worried about is that in the current
> state the API endpoint might expose more internal structure than
> necessary and should at least be documented in the API schema and/or
> abstracted away.
> 
> @Thomas do you have an opinion on this?
I'd leave it out for now, that transition could be conveyed in the HA
status in any case and also for the node entries in /cluster/resources,
it could be argued that doing the latter only makes really sense once
the maintenance mode is really generic, but not _that_ hard feelings
here; in any case, with the status there we can cheaply show a
maintenance icon in the web UI's resource tree.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel