From: Christian Ebner <c.ebner@proxmox.com>
To: David Riley <d.riley@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{,-backup} 00/20] fix #7251: implement server side encryption support for push sync jobs
Date: Wed, 8 Apr 2026 17:11:54 +0200 [thread overview]
Message-ID: <7a42d957-4671-4c1a-ad17-ff2d168e4c0a@proxmox.com> (raw)
In-Reply-To: <1d62a310-86c5-4586-ad38-b1092bf3cd61@proxmox.com>
On 4/8/26 9:28 AM, David Riley wrote:
> Thanks for your work on this.
> I tested your patches for the proxmox and proxmox-backup
> repositories and encountered three issues:
>
> 1. Push/Pull Job: Form validation error
> When the encryption key selection is left untouched or disabled,
> the form fails validation.
>
> Reproduction Steps:
> Use two PBS instances (PBS1 with patches, PBS2 without).
> Create a datastore and an encryption key on PBS1.
> Create a datastore on PBS2.
> On PBS1, configure a Push Job for the datastore.
> Leave the Encryption Key field disabled/untouched and submit the
> form.
>
> The following error appears:
> parameter verification errors (400)
> encryption-key: value must be at least 3 characters long
>
> 2. Deleting Encryption Key: "Unknown error" pop-up
>
> Deleting an encryption key appears to succeed (the key is removed),
> but the UI shows an error pop up.
>
> Error message: "Unknown error"
> Observations: No errors are logged in the browser console or the
> network tab.
>
> 3. Drag and Drop of Encryption Key File
> Dragging a file from the file explorer into the "Upload from File"
> form field results in a parsing error.
>
> Reproduction Steps:
> Create Encryption Key and download it.
> Add new key
> Drag and drop the just downloaded key file into the form field.
>
> The field displays "[object ProgressEvent]" instead of the file
> content/name. Hovering over it shows:
> "Failed to parse key - SyntaxError: JSON parse unexpected character
> at line 1 column 2 of the JSON data"
>
> Aside from these three points, the rest of the functionality works as
> expected.
>
Thanks a lot for testing and reporting these issues: 1. and 2. have
already been reported by others and already fixed for the upcoming
version 2.
Looking into 3. now, thanks for catching that!
next prev parent reply other threads:[~2026-04-08 15:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 7:55 Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox 01/20] pbs-api-types: define encryption key type and schema Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox 02/20] pbs-api-types: sync job: add optional encryption key to config Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 03/20] pbs-key-config: introduce store_with() for KeyConfig Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 04/20] pbs-config: implement encryption key config handling Christian Ebner
2026-04-01 23:27 ` Thomas Lamprecht
2026-04-02 7:09 ` Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 05/20] pbs-config: acls: add 'encryption-keys' as valid 'system' subpath Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 06/20] ui: expose 'encryption-keys' as acl subpath for 'system' Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 07/20] api: config: add endpoints for encryption key manipulation Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 08/20] api: config: allow encryption key manipulation for sync job Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 09/20] sync: push: rewrite manifest instead of pushing pre-existing one Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 10/20] sync: add helper to check encryption key acls and load key Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 11/20] fix #7251: api: push: encrypt snapshots using configured encryption key Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 12/20] ui: define and expose encryption key management menu item and windows Christian Ebner
2026-04-01 23:09 ` Thomas Lamprecht
2026-04-03 8:35 ` Dominik Csapak
2026-04-01 23:10 ` Thomas Lamprecht
2026-04-03 12:16 ` Dominik Csapak
2026-04-01 7:55 ` [PATCH proxmox-backup 13/20] ui: expose assigning encryption key to sync jobs Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 14/20] sync: pull: load encryption key if given in job config Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 15/20] sync: expand source chunk reader trait by crypt config Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 16/20] sync: pull: introduce and use decrypt index writer if " Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 17/20] sync: pull: extend encountered chunk by optional decrypted digest Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 18/20] sync: pull: decrypt blob files on pull if encryption key is configured Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 19/20] sync: pull: decrypt chunks and rewrite index file for matching key Christian Ebner
2026-04-01 7:55 ` [PATCH proxmox-backup 20/20] sync: pull: decrypt snapshots with matching encryption key fingerprint Christian Ebner
2026-04-02 0:25 ` [PATCH proxmox{,-backup} 00/20] fix #7251: implement server side encryption support for push sync jobs Thomas Lamprecht
2026-04-02 7:37 ` Christian Ebner
2026-04-08 7:50 ` Fabian Grünbichler
2026-04-08 8:13 ` Christian Ebner
2026-04-08 8:29 ` Thomas Lamprecht
2026-04-08 8:56 ` Christian Ebner
2026-04-08 9:03 ` Fabian Grünbichler
2026-04-03 8:39 ` Dominik Csapak
2026-04-03 8:50 ` Christian Ebner
2026-04-03 9:00 ` Dominik Csapak
2026-04-07 15:12 ` Manuel Federanko
2026-04-07 16:17 ` Christian Ebner
2026-04-08 7:29 ` David Riley
2026-04-08 15:11 ` Christian Ebner [this message]
2026-04-10 16:56 ` superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a42d957-4671-4c1a-ad17-ff2d168e4c0a@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.